Avoid unnecessary recompilations by snoyberg · Pull Request #4273 · commercialhaskell/stack

snoyberg · 2018-08-30T13:29:15Z

This PR reduces the number of modules in the codebase which enable either TemplateHaskell or CPP, via a few techniques:

Moving conditional code into separate Windows and Unix directories
Moving all of the Store-related TH into a single module
Moving mkRelDir and mkRelFile calls into Stack.Constants
Replacing a few CPP usages with runtime checking of the OS, which I prefer using anyway (it reduces the amount of code which is only built on one OS or the other)

There should be no impact from these changes besides how it affects compile time.

snoyberg · 2018-08-30T13:53:00Z

Note that this resolves #4272

It seems disabling CPP and TemplateHaskell allows hlint to detect other unused pragmas.

Move all mkRel TH calls into Stack.Constants (fixes #4272)

f4a580f

snoyberg mentioned this pull request Aug 30, 2018

Improved recompilation avoidance #4272

Closed

snoyberg force-pushed the reduce-template-haskell branch from 3ed71cb to ef5f082 Compare August 31, 2018 05:58

snoyberg added 3 commits August 31, 2018 10:30

Reduce CPP usage as well #4272

73e713b

Move store-related TH into its own module #4272

a80fd54

hlint: remove unneeded LANGUAGE pragmas

241aa55

It seems disabling CPP and TemplateHaskell allows hlint to detect other unused pragmas.

snoyberg force-pushed the reduce-template-haskell branch from ef5f082 to 241aa55 Compare August 31, 2018 07:31

snoyberg merged commit 0740444 into master Sep 3, 2018

snoyberg deleted the reduce-template-haskell branch September 3, 2018 05:35

Provide feedback