Skip to content

Add tztime #6710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged

Conversation

dcastro
Copy link
Contributor

@dcastro dcastro commented Sep 12, 2022

I ran the verify-package script and ran into the same error as #5014 and #6371 (we have a test suite that uses doctest-parallel), so I added tztime to the expected-haddock-failures section as well.

doctest-parallel> Cabal-simple_mPHDZzAJ_3.6.3.0_ghc-9.2.4: internal error when calculating
doctest-parallel> Documentation created:
doctest-parallel> transitive package dependencies.
doctest-parallel> .stack-work/dist/x86_64-linux-tinfo6/Cabal-3.6.3.0/doc/html/doctest-parallel/index.html,
doctest-parallel> Debug info: [] 

Checklist:

  • Meaningful commit message, eg add my-cool-package (please don't mention build-constraints.yml)
  • At least 30 minutes have passed since uploading to Hackage
  • If applicable, required system libraries are added to 02-apt-get-install.sh or 03-custom-install.sh
  • (optional) Package is compatible with the latest version of all dependencies (Run cabal update && cabal outdated)
  • (optional) Package have been verified to work with the latest nightly snapshot, e.g by running the verify-package script

The script runs virtually the following commands in a clean directory:

  stack unpack $package-$version # `-$version` is optional
  cd $package-$version
  rm -f stack.yaml && stack init --resolver nightly --ignore-subdirs
  stack build --resolver nightly --haddock --test --bench --no-run-benchmarks

@mihaimaruseac mihaimaruseac merged commit 327cd2c into commercialhaskell:master Sep 12, 2022
@ysangkok
Copy link
Contributor

Why is issue #5014 linked? Doesn't seem relevant to this package.

@dcastro
Copy link
Contributor Author

dcastro commented Sep 13, 2022

Why is issue #5014 linked? Doesn't seem relevant to this package.

@ysangkok The error message is extremely similar to the message in #5014 and #6371, so I thought there's a decent chance the root cause is the same.

The hw-ip, hw-json and doctest-parallel packages are all listed in expected-haddock-failures with a comment pointing to #5104, so I thought it made sense to do that too.

Would you like me to remove this comment from tztime?

@dcastro dcastro deleted the diogo/tztime-0.1.0.0 branch September 13, 2022 19:29
@ysangkok
Copy link
Contributor

Would you like me to remove this comment from tztime?

Oh, no, I just thought it was a copy paste error. Makes sense now, thanks for explaining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants