-
-
Notifications
You must be signed in to change notification settings - Fork 281
Homebrew Update #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homebrew Update #278
Conversation
Error seems unrelated:
|
I'm still trying to understand this issue. It seems related to https://mypy.readthedocs.io/en/stable/generics.html#variance-of-generic-types |
I think it's related to questionary, but not sure. |
I've opened a ticket on mypy python/mypy#9555 |
I think that is not actually a bug but rather how mypy is designed. The error message of this issue is as followed.
In mypy doc, it explains how we might be able to solve this problem. However, the type annotation is located in questionary. I'm still trying to figure out what's the better way to solve this problem. As for line 82, it's probably an error I created. I discussed it with the author or #279 offline, we'll fix that one. |
Can u rebase the PR? Thanks |
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
+ Coverage 96.62% 96.96% +0.33%
==========================================
Files 33 33
Lines 919 923 +4
==========================================
+ Hits 888 895 +7
+ Misses 31 28 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hopefully that should do it, although let me know if it didn't. I'm happy to squash my commits if necessary, although I left them as two separate ones since one's for the docs and the other is for the workflow. (I like the summary above ☝by the way) |
Left them as separate commits is great! Thanks for your great work! Let's merge it 😃 |
Description
Following the addition of commitizen to homebrew, I've updated the docs and added a Github Action.
The workflow depends on a Personal Access Token being made available for it.
Checklist
./script/format
and./script/test
locally to ensure this change passes linter check and testExpected behavior
Whenever a release is published, a PR should be sent to update the Homebrew formula.
Steps to Test This Pull Request
N/A
Additional context
Closes #256
Github Action based on #256 (comment) and nef's workflow.
An example of nef's workflow being run successfully can be found here