Add llvm 19 #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

vgvassilev merged 2 commits into compiler-research:main from mcbarton:llvm-19

Aug 1, 2024

Collaborator

mcbarton commented Jul 29, 2024

This PR will make CppInterOp compatible with llvm 19.

codecov bot commented Jul 29, 2024 •

edited

Loading

Codecov Report

Attention: Patch coverage is 62.06897% with 11 lines in your changes missing coverage. Please review.

Project coverage is 72.54%. Comparing base (cff06c7) to head (93caa54).

Files	Patch %	Lines
lib/Interpreter/CppInterOp.cpp	61.53%	10 Missing ⚠️
lib/Interpreter/Paths.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
- Coverage   72.69%   72.54%   -0.16%     
==========================================
  Files           8        8              
  Lines        2963     2972       +9     
==========================================
+ Hits         2154     2156       +2     
- Misses        809      816       +7

Files	Coverage Δ
lib/Interpreter/Compatibility.h	`88.65% <ø> (ø)`
lib/Interpreter/CppInterOpInterpreter.h	`75.94% <100.00%> (ø)`
lib/Interpreter/DynamicLibraryManager.h	`90.00% <100.00%> (ø)`
lib/Interpreter/Paths.cpp	`27.75% <0.00%> (ø)`
lib/Interpreter/CppInterOp.cpp	`79.06% <61.53%> (-0.31%)`	⬇️

Files	Coverage Δ
lib/Interpreter/Compatibility.h	`88.65% <ø> (ø)`
lib/Interpreter/CppInterOpInterpreter.h	`75.94% <100.00%> (ø)`
lib/Interpreter/DynamicLibraryManager.h	`90.00% <100.00%> (ø)`
lib/Interpreter/Paths.cpp	`27.75% <0.00%> (ø)`
lib/Interpreter/CppInterOp.cpp	`79.06% <61.53%> (-0.31%)`	⬇️

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

clang-tidy made some suggestions

lib/Interpreter/CppInterOp.cpp Outdated Show resolved Hide resolved

Contributor

github-actions bot commented Jul 30, 2024

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments

Contributor

github-actions bot commented Jul 30, 2024

clang-tidy review says "All clean, LGTM! 👍"

Contributor

github-actions bot commented Jul 31, 2024

clang-tidy review says "All clean, LGTM! 👍"

mcbarton force-pushed the llvm-19 branch from d23b62b to b65dee1 Compare

July 31, 2024 19:57


          Make CppInterOp compatible with llvm 19

2283dea

mcbarton force-pushed the llvm-19 branch from b65dee1 to 2283dea Compare

July 31, 2024 19:57

Contributor

github-actions bot commented Jul 31, 2024

clang-tidy review says "All clean, LGTM! 👍"

mcbarton marked this pull request as ready for review

July 31, 2024 20:59

vgvassilev reviewed

View reviewed changes

lib/Interpreter/CppInterOp.cpp Outdated Show resolved Hide resolved

unittests/CppInterOp/ScopeReflectionTest.cpp Outdated Show resolved Hide resolved

mcbarton force-pushed the llvm-19 branch from 165da9c to 5103e2e Compare

August 1, 2024 08:17


          Apply suggestions to PR

93caa54

Co-Authored-By: Vassil Vassilev <[email protected]>

mcbarton force-pushed the llvm-19 branch from c4f4bbb to 93caa54 Compare

August 1, 2024 08:18

Contributor

github-actions bot commented Aug 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

vgvassilev approved these changes

View reviewed changes

Contributor

vgvassilev left a comment

LGTM! Thank you @mcbarton!

mcbarton requested a review from vgvassilev

August 1, 2024 09:08

vgvassilev merged commit 34186d6 into compiler-research:main

56 of 59 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet