Skip to content

skipFailures: boolean | axe.ImpactValue[] = false -- allow handling imacts #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mwmcode
Copy link

@mwmcode mwmcode commented Dec 14, 2020

Hello,

Can we have skipFailures accept array of impacts to skip (log/warn)? (so it'd be skipFailures: boolean | axe.ImpactValue[] = false)

Currently it either skips/logs all violations or asserts all.

There are scenarios where one might want to see warnings for certain impact violations while letting other violations fail the test if they are not met.
For example: log warning about color-contrast but fail when missing aria-label

@sapegin
Copy link
Member

sapegin commented Dec 14, 2020

This should be covered by the shouldFail option in the new API: #75

@mwmcode
Copy link
Author

mwmcode commented Dec 14, 2020

I have actually read/upvoted that already but somehow missed the shouldFail part. Looks neat, any release date estimation?

@mwmcode mwmcode closed this Dec 14, 2020
@mwmcode mwmcode reopened this Feb 25, 2021
@mwmcode
Copy link
Author

mwmcode commented Feb 25, 2021

Re-openning for consideration (since it's not a breaking change, and might also be a bridge to the next release where passing callback will be the way to handle assertion failures), since the next major release doesn't seem to be coming soon?

@mwmcode mwmcode closed this Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants