Skip to content

feat: Allow Cypress 7 #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

feat: Allow Cypress 7 #91

wants to merge 3 commits into from

Conversation

jonbot
Copy link

@jonbot jonbot commented Apr 14, 2021

This just bumps up the peer dependencies to allow Cypress 7, which was released on 4/5/21.

@jonbot
Copy link
Author

jonbot commented Apr 14, 2021

Yikes ... it took me a couple times to get package-lock.json right.

@jonbot jonbot mentioned this pull request Apr 14, 2021
Closed
@danWatkinson
Copy link

👍 plus one vote please - the absence of this is causing me much pain..

filipsnopek
filipsnopek approved these changes May 11, 2021
View reviewed changes
Copy link

@filipsnopek filipsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@pongells
Copy link

Any plans to merge this? :) Thanks!

@danielcolas93
Copy link

Will this PR be merged soon? 😅

@kevinccbsg
Copy link

any plans to merge this? Thanks!

@mwmcode
Copy link

mwmcode commented May 31, 2021

Hi folks, you can checkout https://github.com/mcha-dev/cypress-axe-core

I was waiting for this and RFC75 to get merged but there hasn't been much activity on either so I ended up

  1. forking it,
  2. updating its dependencies,
  3. implementing some RFC75

Feedback is welcome

wan54
wan54 reviewed Jun 3, 2021
View reviewed changes
package.json
@@ -30,14 +30,14 @@
"dependencies": {},
"peerDependencies": {
"axe-core": "^3 || ^4",
"cypress": "^3 || ^4 || ^5 || ^6"
"cypress": "^3 || ^4 || ^5 || ^6 || ^7"
Copy link

@wan54 wan54 Jun 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this library would ever not be supported on future cypress releases from v3?

Should it be just >= 3?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested with Cypress 8 and everything seems to be working well

@BHunter2889
Copy link

Can this be Merged and released now? Trying to implement this in an enterprise app running Cypress 7.6 asap and I'd much rather do it the clean way...

@Steph-Rancourt Steph-Rancourt mentioned this pull request Jul 15, 2021
Merged
4 tasks
@vijar50
Copy link

vijar50 commented Aug 3, 2021

Pinging this to be merged in.

@camillef camillef mentioned this pull request Aug 5, 2021
Merged
@smmccabe
Copy link

smmccabe commented Feb 3, 2022

cypress-axe appears to support "cypress": "^3 || ^4 || ^5 || ^6 || ^7 || ^8 || ^9" now so I think this MR can be closed.

@bmordue bmordue closed this Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wan54 wan54 wan54 left review comments

@vibdev vibdev vibdev left review comments

@filipsnopek filipsnopek filipsnopek approved these changes

@cshouts-tasc cshouts-tasc cshouts-tasc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.