First attempt at Conan package for system-installed Avahi Apple Bonjour compatibility library #6928

garethsb · 2021-08-19T11:33:52Z

Specify library name and version: ~~avahi-system/system~~ avahi-mdnsresponder/system

I have named this avahi-system named this avahi-mdnsresponder and used version="system" since I think it would be possible to make ~~other packages~~ packages for other components of Avahi and other recipe versions that built from the source at https://github.com/lathiat/avahi, but I believe most users will want to use the installer package for their system.

I have tested the apt install locally, the yum, pacman and zypper package lists are my best guess only.

I'm not sure precisely what needs to go in the package_info, e.g. system_libs, includedirs, libdirs.

Presumably this will need white-listing in order to build in CI.
@uilianries, @madebr, @prince-chrismc, thanks for your help so far!
I will submit a second PR for building mDNSResponder from the Apple tarballs.

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

…iscovery for Linux using mDNS/DNS-SD - compatible with Bonjour

recipes/avahi-system/all/conanfile.py

…so that "from source" versions can (later) have a different recipe

recipes/avahi/system/test_package/conanfile.py

Co-authored-by: Anonymous Maarten <[email protected]>

recipes/avahi/system/conanfile.py

Co-authored-by: Anonymous Maarten <[email protected]>

ericLemanissier · 2021-08-20T07:33:50Z

FYI, this PR fails on opensuse tumbleweed: https://github.com/bincrafters/system-packages-checks/runs/3379541409?check_suite_focus=true#step:6:330, leap: https://github.com/bincrafters/system-packages-checks/runs/3379541449?check_suite_focus=true#step:6:536. Both these errors should be solved by the code suggestion below (replacing libdns_sd with avahi-compat-mDNSResponder-devel).
there is another error on centos8: https://github.com/bincrafters/system-packages-checks/runs/3380619317?check_suite_focus=true#step:6:343 Error: Unable to find a match: avahi-tools. This does not seem to be available : https://forums.centos.org/viewtopic.php?t=71858. Do you think we can simply remove it ?

Croydon · 2021-08-20T08:04:53Z

but I believe most users will want to use the installer package for their system.

Could you please explain your reasoning why your think that most users want to get it from their system package manager? Do you fear incompatibilities?

recipes/avahi/system/conanfile.py

@ericLemanissier

… Bonjour compatibility library, and use the right package name for openSUSE (thanks, @ericLemanissier)

garethsb · 2021-08-20T12:29:32Z

but I believe most users will want to use the installer package for their system.

Could you please explain your reasoning why your think that most users want to get it from their system package manager? Do you fear incompatibilities?

I'm not sure how closely coupled the daemon and client shared libraries are. Maybe I'm being overly cautious. :-/

ericLemanissier · 2021-08-20T12:51:24Z

on the distro side, it's now fine everywhere.
Are you sure that avahi/system is the proper name for this package ? Maybe we should be a little more specific, in order to be able to have packages for other avahi-foo packages built from https://github.com/lathiat/avahi ?
And as @Croydon said, a rationale is needed regarding the compatibility between system installed avahi and this library.

garethsb · 2021-08-20T12:58:17Z

on the distro side, it's now fine everywhere.
Are you sure that avahi/system is the proper name for this package ? Maybe we should be a little more specific, in order to be able to have packages for other avahi-foo packages built from https://github.com/lathiat/avahi ?

avahi-libdns_sd or avahi-mdnsresponder (keeping version="system" to allow for future building from source) perhaps?
And add a provides as @prince-chrismc suggested?

…ahi to provide the Apple Bonjour compatibility library

prince-chrismc · 2021-08-20T13:30:43Z

~~zap~~

…an-io#6937

recipes/avahi-mdnsresponder/system/conanfile.py

Co-authored-by: SpaceIm <[email protected]>

SpaceIm · 2021-08-20T15:16:17Z

recipes/avahi-mdnsresponder/config.yml

+  "system":
+    folder: system


As @Croydon has pointing out, is it the good approach? I'm not comfortable with adding a new system library while source code is available.

I started work on an avahi recipe from the source package. The configure script has 25 --enable-xxx options and a further 10 arguments for those options. It will need a new recipe for libdaemon for sure, and several other new recipes if all the options are ultimately to be supported.

Consumers of avahi are already using the system package manager, which goes the extra mile to setup the startup scripts for the daemon. Which could be added as a deploy step in downstream recipes to be installed but I am not sure how that would work in CCI.

Even if we build from source we won't be able to correctly install the daemon for that platform.
This give Consumers the option to build and deploy against a target platform and not have to re-invite too many things.

Having the recipe would be a huge advantage to "us" because it blends so nicely with the solutions we've already deployed and are working for end-users.

We all agree from source is ideal but in some cases, id argue like this, offer a few key advantages.
This does not prevent us from adding it in the future.

conan-center-bot · 2021-08-20T15:22:40Z

All green in build 7 (2c49a8594e3ec9a1fb931078d34835104c18dbc8):

avahi-mdnsresponder/system@:
All packages built successfully! (All logs)

garethsb · 2021-08-27T07:50:55Z

Closing in favour of #7049 which builds Avahi from source.

* nmos-cpp recipe files copied from sony/nmos-cpp#195 * Add config.yml for current tip of garethsb:library-cmake * Attempt to install Avahi Apple Bonjour compatibility library on Linux * Provide with_dnssd options based on #6928, #6930, #6937 * Fix typo in prev commit * Simplify selection of appropriate requirements for DNS-SD * For now, keep default option as mdnsresponder on Windows and Linux * Leave most exceptions uncaught as they really aren't expected in the test_package (cf. the best practice shown in nmos-cpp-node example app) but do catch web::http::http_exception since the most likely cause of that is a port being in use or, on Windows with cpprestsdk built with its default settings, that the test_package wasn't run as administrator, which WinHTTP enforces to listen on the wildcard hostname. Uncaught exceptions, via std::terminate, end up as STATUS_STACK_BUFFER_OVERRUN on Windows (see https://devblogs.microsoft.com/oldnewthing/20190108-00/?p=100655), which Conan reports as "ConanException: Error 3221226505 while executing bin\test_package", which might take one a while to understand, if one didn't already know all of this... * Update to head revision of garethsb:library-cmake and latest mdnsresponder (#6930) and avahi (#7049) from-source recipes, since those seem more likely to be approved on CCI * Better comment * Switch to upstream sony/nmos-cpp (sony/nmos-cpp#195 was merged to master) * self.options.get_safe("with_dnssd") * For now, to build on CCI, don't require the opt-in patches * Build requires CMake 3.17 * Hopefully using short paths will resolve "fatal error C1083: Cannot open compiler generated file: '': Invalid argument" on some Windows builds on CCI * Test package requires C++11 * int64_t should work everywhere... I think * Test proposed upstream fix to make relocatable package per https://cmake.org/cmake/help/latest/manual/cmake-packages.7.html#creating-relocatable-packages * Fix handling of ${_IMPORT_PREFIX} * Fix handling of ${_IMPORT_PREFIX} and add tools.check_min_cppstd * No version ranges * Log all exceptions to debug intermittent test_package failure on arch=x86_64, build_type=Release, compiler=Visual Studio, compiler.runtime=MT, compiler.version=14, os=Windows * Additional warning * Take upstream latest which merged the relocatable package fix (cf. bf1388a) * Update conanfile.py * Apply suggestions from code review (properly) Co-authored-by: Anonymous Maarten <[email protected]> * Apply suggestions from code review Co-authored-by: Anonymous Maarten <[email protected]> * Apply suggestions from code review Co-authored-by: Anonymous Maarten <[email protected]> * self.options["mdnsresponder"].with_opt_patches = True * Apply suggestions from code review Co-authored-by: Uilian Ries <[email protected]> * cmake/3.21.1 conflicts with openssl/1.1.1l * Update topics * Try bump openssl/1.1.1l and cmake/3.21.2 * Take upstream latest, now built and tested with OpenSSL v1.1.1L Co-authored-by: Anonymous Maarten <[email protected]> Co-authored-by: Uilian Ries <[email protected]>

First attempt at Conan package for system-installed Avahi - Service D…

8a4793b

…iscovery for Linux using mDNS/DNS-SD - compatible with Bonjour

This comment has been minimized.

Sign in to view

github-actions bot mentioned this pull request Aug 19, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

prince-chrismc previously approved these changes Aug 19, 2021

View reviewed changes

recipes/avahi-system/all/conanfile.py Outdated Show resolved Hide resolved

recipes/avahi-system/all/conanfile.py Outdated Show resolved Hide resolved

garethsb mentioned this pull request Aug 19, 2021

First attempt at Conan package for Apple's mDNSResponder #6930

Merged

4 tasks

Renamed avahi-system to avahi, with "all" folder renamed to "system" …

cd992f4

…so that "from source" versions can (later) have a different recipe

garethsb dismissed prince-chrismc’s stale review via cd992f4 August 19, 2021 16:38

This comment has been minimized.

Sign in to view

prince-chrismc previously approved these changes Aug 19, 2021

View reviewed changes

madebr reviewed Aug 19, 2021

View reviewed changes

recipes/avahi/system/test_package/conanfile.py Outdated Show resolved Hide resolved

Update recipes/avahi/system/test_package/conanfile.py

71740f6

Co-authored-by: Anonymous Maarten <[email protected]>

garethsb dismissed prince-chrismc’s stale review via 71740f6 August 19, 2021 19:36

madebr reviewed Aug 19, 2021

View reviewed changes

recipes/avahi/system/conanfile.py Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Update recipes/avahi/system/conanfile.py

e674181

Co-authored-by: Anonymous Maarten <[email protected]>

This comment has been minimized.

Sign in to view

SSE4 requested a review from uilianries August 20, 2021 06:52

ericLemanissier reviewed Aug 20, 2021

View reviewed changes

recipes/avahi/system/conanfile.py Outdated Show resolved Hide resolved

ericLemanissier reviewed Aug 20, 2021

View reviewed changes

recipes/avahi/system/conanfile.py Outdated Show resolved Hide resolved

Only install the one package necessary for building against the Avahi…

ae95013

… Bonjour compatibility library, and use the right package name for openSUSE (thanks, @ericLemanissier)

This comment has been minimized.

Sign in to view

garethsb mentioned this pull request Aug 20, 2021

First attempt at Conan package for Apple's Bonjour #6937

Closed

4 tasks

Rename to avahi-mdnsresponder to indicate only packaging enough of Av…

da5fe9b

…ahi to provide the Apple Bonjour compatibility library

garethsb added a commit to garethsb/conan-center-index that referenced this pull request Aug 20, 2021

Add provides = "mdnsresponder" (cf. conan-io#6937, conan-io#6928)

1a1526b

This comment has been minimized.

Sign in to view

garethsb added a commit to garethsb/conan-center-index that referenced this pull request Aug 20, 2021

Provide with_dnssd options based on conan-io#6928, conan-io#6930, con…

43de7c4

…an-io#6937

SpaceIm reviewed Aug 20, 2021

View reviewed changes

recipes/avahi-mdnsresponder/system/conanfile.py Outdated Show resolved Hide resolved

Update recipes/avahi-mdnsresponder/system/conanfile.py

2c49a85

Co-authored-by: SpaceIm <[email protected]>

SpaceIm reviewed Aug 20, 2021

View reviewed changes

This was referenced Aug 24, 2021

Add libdaemon #7028

Merged

Add Avahi #7049

Merged

garethsb closed this Aug 27, 2021

First attempt at Conan package for system-installed Avahi Apple Bonjour compatibility library #6928

First attempt at Conan package for system-installed Avahi Apple Bonjour compatibility library #6928

Uh oh!

Conversation

garethsb commented Aug 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

ericLemanissier commented Aug 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Croydon commented Aug 20, 2021

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

garethsb commented Aug 20, 2021

Uh oh!

ericLemanissier commented Aug 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

garethsb commented Aug 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prince-chrismc commented Aug 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

SpaceIm Aug 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

garethsb Aug 21, 2021

Choose a reason for hiding this comment

Uh oh!

prince-chrismc Aug 21, 2021

Choose a reason for hiding this comment

Uh oh!

conan-center-bot commented Aug 20, 2021

Uh oh!

garethsb commented Aug 27, 2021

Uh oh!

Uh oh!

garethsb commented Aug 19, 2021 •

edited

Loading

ericLemanissier commented Aug 20, 2021 •

edited

Loading

ericLemanissier commented Aug 20, 2021 •

edited

Loading

garethsb commented Aug 20, 2021 •

edited

Loading

prince-chrismc commented Aug 20, 2021 •

edited

Loading

SpaceIm Aug 20, 2021 •

edited

Loading