Make the create_feedstocks script compatible with the PyGitHub 2.7.0 API
#1600
Conversation
shermansiu
changed the title
create_feedstocks script compatible with the 2.7.0 APIcreate_feedstocks script compatible with the PyGitHub 2.7.0 API
- The current create_feedstocks actions keep crashing (e.g. https://github.com/conda-forge/admin-requests/actions/runs/16696874176) - The PyGitHub repo recently changed up their API in a backwards-incompatible way, which led to this problem - https://github.com/PyGithub/PyGithub/releases/tag/v2.7.0
shermansiu
force-pushed
the
fix/update_compatible_pygithub_2_7_0
branch
from
678869b to
e1d6348
Compare
|
Thanks for digging into this. For now I think I'd prefer to add admin-requests/scripts/create_feedstocks Line 48 in 80e2b9b (also in environment.yaml) and then later do an explicit changeover to the new API (who needs semantic versioning anyway? 🤦♂️) while raising the lower bound
|
|
Or at least they could havea |
|
@h-vetinari ill try to make the Pr to limit pygithub. But would you be ok with us using hasattr to write compatibility shims for both pre 2.7 and 2.7. At least for the next 6 months while the API stabilizes. |
Sure! My point was that we should only use the bare pre-2.7 or post-2.7 API, if we accompany it with version bounds in the environment. But if you write a shim that works both before and after, even better! |
This would still be the correct fix to stop the bleeding IMO, and then follow up with #1602 which can remove the limit again |
create_feedstocksactions keep crashing (e.g. https://github.com/conda-forge/admin-requests/actions/runs/16696874176)create_feedstocksaction started crashing 2 days ago, which is exactly when the v2.7.0 PyGitHub version got released.Other potential fixes
verificationdoes not appear in this repo, so we don't need to fix that (https://github.com/search?q=repo%3Aconda-forge%2Fadmin-requests%20verification&type=code)get_rate_limitin this repo is inscripts/create_feedstocks.py, so this is the only part of the repo that needs to be fixed (https://github.com/search?q=repo%3Aconda-forge%2Fadmin-requests%20get_rate_limit&type=code)