Skip to content

Update to 1.12 #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 4, 2019
Merged

Update to 1.12 #54

merged 22 commits into from
Jul 4, 2019

Conversation

sodre
Copy link
Member

@sodre sodre commented Mar 14, 2019

xref: #53

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@sodre
Copy link
Member Author

sodre commented Mar 14, 2019

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to {} for you but ran into some issues, please ping conda-forge/core for further assistance.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@mariusvniekerk
Copy link
Member

@conda-forge-admin please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you but ran into some issues, please ping conda-forge/core for further assistance.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@mariusvniekerk
Copy link
Member

Recipe fails to lint, but that is kinda normal

@mrocklin
Copy link

mrocklin commented Jul 1, 2019

Checking in, what's the status here? Is there anything we can do to push on this? It'd be handy for some Dask work.

@mrocklin
Copy link

mrocklin commented Jul 1, 2019

(cc @jakirkham)

@scopatz
Copy link
Member

scopatz commented Jul 1, 2019

@conda-forge-admin please rerender

@mrocklin
Copy link

mrocklin commented Jul 1, 2019

For context, I ran into this when trying to install dask-gateway (which I imagine is also why @jcrist cares about this)

@scopatz
Copy link
Member

scopatz commented Jul 1, 2019

Any help is welcome on this!

@stuarteberg
Copy link
Contributor

I don't have much to offer, but here's what I see so far.

The errors on Windows and Linux are different. On Windows, the build fails with some problem in the recipe:

ValueError: All packages in zip keys must belong to only one group.  'None' is in more than one group.

Presumably, that's referring to some sort of problem in conda_build_config.yaml, but I don't see anything obviously wrong there.

Meanwhile, one of the linux configurations fails with error messages like this:

runtime/cgo(.text.fatalf): relocation target stderr not defined for ABI0 (but is defined for ABI0)

Googling for that leads you to the following comment from none other than our good friend @jakirkham:
golang/go#23649 (comment)

So, I guess someone should try adding -ldflags="-linkmode=external" to some line in build-core.sh? I'm not quite sure where, though....

@mariusvniekerk
Copy link
Member

mariusvniekerk commented Jul 2, 2019

this might go into the CGO_LDFLAGS env var?

@mariusvniekerk
Copy link
Member

unclear where this goes now?

@mariusvniekerk
Copy link
Member

Seems cgo is REALLY wanting something called gcc during its bootstrap phase, so maybe some symlinks?

@mariusvniekerk
Copy link
Member

Not entirely sure if cgo is correct here, but it does build??

@mariusvniekerk
Copy link
Member

@conda-forge-admin please rerender

@mariusvniekerk
Copy link
Member

@sodre Should we just merge this and fix the windows part in a follow on?

@scopatz
Copy link
Member

scopatz commented Jul 3, 2019

I am OK with that

@sodre sodre merged commit f26cafe into conda-forge:master Jul 4, 2019
@sodre sodre deleted the 1.12.0 branch July 4, 2019 01:13
This was referenced Jul 4, 2019
Closed
@jakirkham
Copy link
Member

Raised issue ( #63 ) on the Windows build failure for tracking purposes.

@adbedada
Copy link
Member

adbedada commented Jul 8, 2019

@mariusvniekerk /@sodre did this PR updated just go for linux? The osx version on anaconda/conda-forge still says 1.11.9. If so, w'd creating a PR to update for osx make sense?

@jakirkham
Copy link
Member

For some reason the macOS build passed, but the upload failed. Have restarted in the event that fixes things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants