Skip to content

Rebuild for protobuf423 [ign-msg5]#86

Merged
traversaro merged 10 commits intoconda-forge:v5.3.0from
regro-cf-autotick-bot:rebuild-protobuf423-0-2_h85d81e
Jun 5, 2023
Merged

Rebuild for protobuf423 [ign-msg5]#86
traversaro merged 10 commits intoconda-forge:v5.3.0from
regro-cf-autotick-bot:rebuild-protobuf423-0-2_h85d81e

Conversation

@regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update protobuf423.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5100136875, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro traversaro changed the title Rebuild for protobuf423 Rebuild for protobuf423 [ign-msg5] May 30, 2023
@traversaro
Copy link
Contributor

traversaro commented Jun 4, 2023

There is still a failure on protobuf 23.2 on Windows:

2023-05-31T06:39:38.5802056Z -- Build files have been written to: D:/bld/libignition-msgs5_1685514785465/work/build
2023-05-31T06:39:41.6730317Z [1/366] C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\HostX64\x64\cl.exe   /TP -DNOMINMAX -DPROTOBUF_USE_DLLS -DWIN32_LEAN_AND_MEAN -I%SRC_DIR%\include -I%SRC_DIR%\build\include -external:I%PREFIX%\Library\include -external:W0 /DWIN32 /D_WINDOWS /W3 /GR /EHsc /MD /O2 /Ob2 /DNDEBUG /Gy /W2 /Zi /GL /EHsc /showIncludes /Fosrc\CMakeFiles\ign_msgs_gen.dir\generator_main.cc.obj /Fdsrc\CMakeFiles\ign_msgs_gen.dir\ /FS -c %SRC_DIR%\src\generator_main.cc
2023-05-31T06:39:41.6732964Z FAILED: src/CMakeFiles/ign_msgs_gen.dir/generator_main.cc.obj 
2023-05-31T06:39:41.6735256Z C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\HostX64\x64\cl.exe   /TP -DNOMINMAX -DPROTOBUF_USE_DLLS -DWIN32_LEAN_AND_MEAN -I%SRC_DIR%\include -I%SRC_DIR%\build\include -external:I%PREFIX%\Library\include -external:W0 /DWIN32 /D_WINDOWS /W3 /GR /EHsc /MD /O2 /Ob2 /DNDEBUG /Gy /W2 /Zi /GL /EHsc /showIncludes /Fosrc\CMakeFiles\ign_msgs_gen.dir\generator_main.cc.obj /Fdsrc\CMakeFiles\ign_msgs_gen.dir\ /FS -c %SRC_DIR%\src\generator_main.cc
2023-05-31T06:39:41.6736469Z Microsoft (R) C/C++ Optimizing Compiler Version 19.29.30148 for x64
2023-05-31T06:39:41.6737947Z Copyright (C) Microsoft Corporation.  All rights reserved.
2023-05-31T06:39:41.6738162Z 
2023-05-31T06:39:41.6738499Z cl : Command line warning D9025 : overriding '/W3' with '/W2'
2023-05-31T06:39:41.6738841Z The contents of <string_view> are available only with C++17 or later.
2023-05-31T06:39:41.6739505Z %PREFIX%\Library\include\absl/strings/string_view.h(52): error C2039: 'string_view': is not a member of 'std'
2023-05-31T06:39:41.6739906Z C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.29.30133\include\iterator(21): note: see declaration of 'std'
2023-05-31T06:39:41.6740394Z %PREFIX%\Library\include\absl/strings/string_view.h(52): error C2061: syntax error: identifier 'string_view'
2023-05-31T06:39:41.6740892Z %PREFIX%\Library\include\absl/strings/string_view.h(686): error C7525: inline variables require at least '/std:c++17'
2023-05-31T06:39:41.6741355Z %PREFIX%\Library\include\absl/strings/string_view.h(686): error C2146: syntax error: missing ';' before identifier 'ClippedSubstr'
2023-05-31T06:39:41.6741868Z %PREFIX%\Library\include\absl/strings/string_view.h(686): error C2146: syntax error: missing ')' before identifier 's'
2023-05-31T06:39:41.6742370Z %PREFIX%\Library\include\absl/strings/string_view.h(687): error C2825: 'absl::lts_20230125::string_view': must be a class or namespace when followed by '::'
2023-05-31T06:39:41.6742906Z %PREFIX%\Library\include\absl/strings/string_view.h(687): error C2510: 'string_view': left of '::' must be a class/struct/union
2023-05-31T06:39:41.6743381Z %PREFIX%\Library\include\absl/strings/string_view.h(687): error C2143: syntax error: missing ';' before '{'
2023-05-31T06:39:41.6743816Z %PREFIX%\Library\include\absl/strings/string_view.h(687): error C2447: '{': missing function header (old-style formal list?)
2023-05-31T06:39:41.6744680Z %PREFIX%\Library\include\absl/strings/string_view.h(697): error C2737: 'absl::lts_20230125::string_view': constexpr object must be initialized
2023-05-31T06:39:41.6745475Z %PREFIX%\Library\include\absl/strings/string_view.h(697): error C2373: 'absl::lts_20230125::string_view': redefinition; different type modifiers
2023-05-31T06:39:41.6747193Z %PREFIX%\Library\include\absl/strings/string_view.h(686): note: see declaration of 'absl::lts_20230125::string_view'
2023-05-31T06:39:41.6748251Z %PREFIX%\Library\include\absl/strings/string_view.h(697): error C2146: syntax error: missing ';' before identifier 'NullSafeStringView'
2023-05-31T06:39:41.6748867Z %PREFIX%\Library\include\absl/strings/string_view.h(698): error C2065: 'string_view': undeclared identifier
2023-05-31T06:39:41.6749859Z %PREFIX%\Library\include\absl/strings/string_view.h(698): error C2065: 'string_view': undeclared identifier
2023-05-31T06:39:41.6750390Z %PREFIX%\Library\include\absl/utility/utility.h(164): error C2039: 'in_place_t': is not a member of 'std'
2023-05-31T06:39:41.6750920Z C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.29.30133\include\functional(31): note: see declaration of 'std'
2023-05-31T06:39:41.6751489Z %PREFIX%\Library\include\absl/utility/utility.h(164): error C2873: 'in_place_t': symbol cannot be used in a using-declaration
2023-05-31T06:39:41.6751965Z %PREFIX%\Library\include\absl/utility/utility.h(165): error C2039: 'in_place': is not a member of 'std'
2023-05-31T06:39:41.6752357Z C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.29.30133\include\functional(31): note: see declaration of 'std'
2023-05-31T06:39:41.6753294Z %PREFIX%\Library\include\absl/utility/utility.h(165): error C2873: 'in_place': symbol cannot be used in a using-declaration
2023-05-31T06:39:41.6753964Z %PREFIX%\Library\include\absl/utility/utility.h(181): error C2039: 'in_place_type': is not a member of 'std'
2023-05-31T06:39:41.6754495Z C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.29.30133\include\functional(31): note: see declaration of 'std'
2023-05-31T06:39:41.6755015Z %PREFIX%\Library\include\absl/utility/utility.h(181): error C2873: 'in_place_type': symbol cannot be used in a using-declaration
2023-05-31T06:39:41.6755828Z %PREFIX%\Library\include\absl/utility/utility.h(182): error C2039: 'in_place_type_t': is not a member of 'std'
2023-05-31T06:39:41.6756357Z C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.29.30133\include\functional(31): note: see declaration of 'std'
2023-05-31T06:39:41.6756891Z %PREFIX%\Library\include\absl/utility/utility.h(182): error C2873: 'in_place_type_t': symbol cannot be used in a using-declaration
2023-05-31T06:39:41.6757342Z %PREFIX%\Library\include\absl/utility/utility.h(198): error C2039: 'in_place_index': is not a member of 'std'
2023-05-31T06:39:41.6757810Z C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.29.30133\include\functional(31): note: see declaration of 'std'
2023-05-31T06:39:41.6758341Z %PREFIX%\Library\include\absl/utility/utility.h(198): error C2873: 'in_place_index': symbol cannot be used in a using-declaration
2023-05-31T06:39:41.6758953Z %PREFIX%\Library\include\absl/utility/utility.h(199): error C2039: 'in_place_index_t': is not a member of 'std'
2023-05-31T06:39:41.6759415Z C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.29.30133\include\functional(31): note: see declaration of 'std'
2023-05-31T06:39:41.6759923Z %PREFIX%\Library\include\absl/utility/utility.h(199): error C2873: 'in_place_index_t': symbol cannot be used in a using-declaration
2023-05-31T06:39:41.6760215Z The contents of <optional> are available only with C++17 or later.

it seems that for some reason the usage requirement of C++17 is not propagated.

@traversaro traversaro changed the title Rebuild for protobuf423 [ign-msg5] Rebuild for protobuf423 and update to 5.11.0 [ign-msg5] Jun 4, 2023
@traversaro
Copy link
Contributor

I think I found the bug.

This is how protobuf targets are defined by find_package(Protobuf CONFIG):

add_library(protobuf::libprotobuf-lite SHARED IMPORTED)

set_target_properties(protobuf::libprotobuf-lite PROPERTIES
  INTERFACE_COMPILE_DEFINITIONS "PROTOBUF_USE_DLLS"
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "abseil_dll"
)

# Create imported target protobuf::libprotobuf
add_library(protobuf::libprotobuf SHARED IMPORTED)

set_target_properties(protobuf::libprotobuf PROPERTIES
  INTERFACE_COMPILE_DEFINITIONS "PROTOBUF_USE_DLLS"
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "abseil_dll"
)

# Create imported target protobuf::libprotoc
add_library(protobuf::libprotoc SHARED IMPORTED)

set_target_properties(protobuf::libprotoc PROPERTIES
  INTERFACE_COMPILE_DEFINITIONS "PROTOBUF_USE_DLLS"
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "abseil_dll"
)

The INTERFACE_LINK_LIBRARIES is abseil_dll, but the imported target defined by find_package(absl REQUIRED) is absl::abseil_dll.

@traversaro traversaro changed the title Rebuild for protobuf423 and update to 5.11.0 [ign-msg5] Rebuild for protobuf423 [ign-msg5] Jun 4, 2023
@traversaro
Copy link
Contributor

Ok, I found the problem. The root cause of the problem is fixed by abseil/abseil-cpp#1466, but a temporary fix for protobuf is provided in protocolbuffers/protobuf#12978 .

xref: conda-forge/conda-forge-pinning-feedstock#4075

@traversaro traversaro added the automerge Merge the PR when CI passes label Jun 5, 2023
@traversaro traversaro merged commit 02ff8d5 into conda-forge:v5.3.0 Jun 5, 2023
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-protobuf423-0-2_h85d81e branch June 5, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the PR when CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants