Skip to content

Dynamic attribute support with PyPy#46

Merged
isuruf merged 4 commits intoconda-forge:masterfrom
isuruf:pypy
Mar 27, 2020
Merged

Dynamic attribute support with PyPy#46
isuruf merged 4 commits intoconda-forge:masterfrom
isuruf:pypy

Conversation

@isuruf
Copy link
Copy Markdown
Member

@isuruf isuruf commented Mar 25, 2020

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@conda-forge-linter
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@isuruf isuruf merged commit 0ec2717 into conda-forge:master Mar 27, 2020
@ax3l
Copy link
Copy Markdown
Member

ax3l commented Mar 31, 2020

cross-link: pybind/pybind11#2146

@wjakob
Copy link
Copy Markdown
Contributor

wjakob commented Mar 31, 2020

Am I understanding this correctly that the feedstock is somehow being used as a side-channel to get patches into pybind11 separately from the main GitHub repo? I would be very much against something like this. I realize that I haven't been very responsive recently (particular as of late, there is no day care in Switzerland atm.), but that is no excuse IMO.

@ax3l
Copy link
Copy Markdown
Member

ax3l commented Apr 1, 2020

Yep, same here. I appreciate the upstream contribution a lot but opening and self-merging this PR within a day for an unmerged patch puzzles me.

@chrisburr chrisburr mentioned this pull request Oct 12, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants