Add easybuild recipes to conda #2391

jerowe · 2017-02-09T14:29:38Z

No description provided.

conda-forge-linter · 2017-02-09T14:29:43Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/easybuild, recipes/easybuild-easyblocks, recipes/easybuild-easyconfigs, recipes/easybuild-framework, recipes/vsc-base, recipes/vsc-install) and found some lint.

Here's what I've got...

For recipes/easybuild:

The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
The recipe license should not include the word "License".

For recipes/easybuild-easyblocks:

The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
The recipe license should not include the word "License".

For recipes/easybuild-easyconfigs:

The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
The recipe must have some tests.
The recipe license should not include the word "License".

For recipes/easybuild-framework:

The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
The recipe license should not include the word "License".

For recipes/vsc-base:

The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
The recipe license should not include the word "License".

For recipes/vsc-install:

The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
The recipe license should not include the word "License".

conda-forge-linter · 2017-02-09T14:34:11Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/easybuild, recipes/easybuild-easyblocks, recipes/easybuild-easyconfigs, recipes/easybuild-framework, recipes/vsc-base, recipes/vsc-install) and found some lint.

Here's what I've got...

For recipes/easybuild-easyconfigs:

The recipe must have some tests.

rmax · 2017-02-09T15:46:50Z

To keep your diff clean, there is no need to remove existing recipes.

jerowe · 2017-02-09T15:59:06Z

Thanks, @rolando . I'll keep that in mind.

For now I have many other things wrong. ;-)

conda-forge-linter · 2017-02-09T17:00:34Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/easybuild, recipes/easybuild-easyblocks, recipes/easybuild-easyconfigs, recipes/easybuild-framework, recipes/vsc-base, recipes/vsc-install) and found it was in an excellent condition.

jerowe · 2017-02-09T17:15:49Z

ping @boegel

jerowe · 2017-02-09T18:09:36Z

Ping @jakirkham and @conda-forge/core.

@jakirkham , are you still on leave? Should I quite bugging you?

scopatz · 2017-02-09T18:11:40Z

recipes/bcolz/meta.yaml

@@ -1,56 +0,0 @@
-{% set name = "bcolz" %}


Please don't remove all of the other recipes in the recipes dir. conda-forge knows to only look at the ones you added.

jerowe · 2017-02-09T18:13:10Z

Sorry. Let me add those back.

jakirkham · 2017-02-10T00:14:26Z

@jakirkham , are you still on leave? Should I quite bugging you?

Feel free to bug me. 😄

jakirkham · 2017-02-10T00:18:19Z

recipes/easybuild-framework/meta.yaml

+  home: http://hpcugent.github.com/easybuild
+  license: GPLv2
+  summary: 'The EasyBuild framework supports the creation of custom easyblocks that implement support for installing particular (groups of) software packages.'
+  license_family: GPL2


Is there a license file in the source that we can add to the package using license_file? Maybe the answer is no.

xref: easybuilders/easybuild#301

jakirkham · 2017-02-10T00:18:56Z

recipes/easybuild/build.sh

+
+python setup.py install  \
+	--single-version-externally-managed \
+	--record=record.txt 


This can be moved to build/script and this file dropped.

jakirkham · 2017-02-10T00:19:14Z

recipes/easybuild-framework/build.sh

+
+python setup.py install  \
+	--single-version-externally-managed \
+	--record=record.txt 


This can be moved to build/script and this file dropped.

jakirkham · 2017-02-10T00:20:04Z

recipes/easybuild-framework/meta.yaml

+build:
+  number: 0
+  skip: True  # [py3k]
+  skip: True  # [win]


These can be combined to give...

skip: true # [win or py3k]

jakirkham · 2017-02-10T00:20:25Z

recipes/easybuild-framework/meta.yaml

+    - coloredlogs
+    - humanfriendly
+    - vsc-install >=0.9.19
+    - vsc-base >=2.5.4


Are all of these needed at build time or only at run time?

Run time. It has a framework for running tests of extensions.

jakirkham · 2017-02-10T00:20:32Z

recipes/easybuild/meta.yaml

+    - setuptools
+    - easybuild-easyconfigs ==3.1.0
+    - easybuild-easyblocks ==3.1.0
+    - easybuild-framework ==3.1.0


Are all of these needed at build time or only at run time?

jakirkham · 2017-02-10T00:22:13Z

I'll hold off on doing more review until after the removed recipes are restored. Just so you know, even if there are recipes in recipes they won't build unless you added them in your PR.

…into feature/easybuild

jerowe · 2017-02-10T10:39:19Z

@jakirkham , I think something is up with the travis builds.

conda-forge-linter · 2017-02-10T14:02:21Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/easybuild, recipes/easybuild-easyblocks, recipes/easybuild-easyconfigs, recipes/easybuild-framework, recipes/vsc-base, recipes/vsc-install) and found some lint.

Here's what I've got...

For recipes/easybuild:

There are 1 too many lines. There should be one empty line at the end of the file.

conda-forge-linter · 2017-02-10T16:02:24Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/easybuild, recipes/easybuild-easyblocks, recipes/easybuild-easyconfigs, recipes/easybuild-framework, recipes/vsc-base, recipes/vsc-install) and found it was in an excellent condition.

jakirkham · 2017-02-12T02:19:25Z

Hmm...maybe it was canceled accidentally while doing some cleanup of outdated builds.

jerowe · 2017-02-13T10:25:14Z

@jakirkham , merge?

scopatz · 2017-02-13T19:06:10Z

This has conflicts with master somehow. Please resolve these, @jerowe. Thanks!

…eature/easybuild

jerowe · 2017-02-14T07:18:10Z

@scopatz - I fixed the conflicts.

scopatz · 2017-02-14T14:29:49Z

recipes/easybuild-easyblocks/meta.yaml

+
+about:
+  home: http://hpcugent.github.com/easybuild
+  license: GPLv2


gpl has to have the license_file, as per the terms of the license

ping @boegel

Nevermind, @boegel, that was my oversight. The license file is right there. ;-)

scopatz · 2017-02-14T14:30:25Z

recipes/easybuild/meta.yaml

+
+about:
+  home: http://hpcugent.github.com/easybuild
+  license: GPLv2


Maybe I am missing something, but where is the license file om this one?

Good catch. I just added it.

Ok this time it is really fixed. ;-)

scopatz · 2017-02-14T14:30:44Z

recipes/vsc-base/meta.yaml

+
+about:
+  home: https://github.com/hpcugent/vsc-base
+  license: LPGLv2+


needs license file

conda-forge-linter · 2017-02-15T07:00:07Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/easybuild, recipes/easybuild-easyblocks, recipes/easybuild-easyconfigs, recipes/easybuild-framework, recipes/vsc-base, recipes/vsc-install) and found some lint.

Here's what I've got...

For recipes/easybuild:

The recipe license should not include the word "License".

conda-forge-linter · 2017-02-15T07:00:55Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/easybuild, recipes/easybuild-easyblocks, recipes/easybuild-easyconfigs, recipes/easybuild-framework, recipes/vsc-base, recipes/vsc-install) and found it was in an excellent condition.

scopatz · 2017-02-15T07:50:52Z

woohoo thanks!

boegel · 2017-02-15T09:59:38Z

recipes/easybuild-framework/meta.yaml

+    - coloredlogs
+    - humanfriendly
+    - vsc-install >=0.9.19
+    - vsc-base >=2.5.4


there are a couple of additional (optional) dependencies that may be interesting to include, e.g. keyring (for eb --new-pr), GC3Pie (for eb --job), GitPython (eb --new-pr), pep8 (eb --style-check)

jerowe · 2017-02-15T10:04:24Z

Let me go and investigate how many of these already exist as conda packages. I already got pep8 I think.

…

On Wed, Feb 15, 2017 at 1:59 PM Kenneth Hoste ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In recipes/easybuild-framework/meta.yaml <#2391 (review)> : > + - python + - setuptools >=0.6 + - pyyaml + - coloredlogs + - humanfriendly + - vsc-install >=0.9.19 + - vsc-base >=2.5.4 + + run: + - python + - setuptools >=0.6 + - pyyaml + - coloredlogs + - humanfriendly + - vsc-install >=0.9.19 + - vsc-base >=2.5.4 there are a couple of additional (optional) dependencies that may be interesting to include, e.g. keyring (for eb --new-pr), GC3Pie (for eb --job), GitPython (eb --new-pr), pep8 (eb --style-check) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2391 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFTFRvaXt_-uB2vMwvnLC2PNqdQqAb3Qks5rcsyKgaJpZM4L8MiL> .

trying to add in easybuild frameworks

d1fad15

fixing lint

1a73cf3

jerowe added 2 commits February 9, 2017 19:03

not sure what vcs-install is downloading

fe6eeb0

deps

11612a4

jerowe added 3 commits February 9, 2017 20:54

wheee

064427a

try again

ae99931

adding in dummy test to easybuild-easyconfigs

302383d

jerowe added 2 commits February 9, 2017 21:31

can't get tests working

d6ea2a4

getting rid of post link scripts

3d0de10

scopatz reviewed Feb 9, 2017

View reviewed changes

jakirkham reviewed Feb 10, 2017

View reviewed changes

jerowe added 4 commits February 10, 2017 12:29

develop

08fb3c0

trying to add in easybuild frameworks

4756cdd

fixing lint

3e4948a

not sure what vcs-install is downloading

e5c8160

jerowe added 9 commits February 10, 2017 12:29

getting rid of post link scripts

39c59b7

Merge branch 'feature/easybuild' of github.com:jerowe/staged-recipes …

3ce72e1

…into feature/easybuild

Merge branch 'master' into feature/easybuild

844670e

Merge branch 'upstream'

f2a33bc

Merge branch 'master' into feature/easybuild

6c25353

commiting

e558d78

cleaning up diff

1562cce

fixing

dcaedb3

fixing

b003c23

trying to restart osx build

363962d

fixing lint

501fba5

Merge branch 'master' of github.com:conda-forge/staged-recipes into f…

e70e379

…eature/easybuild

scopatz reviewed Feb 14, 2017

View reviewed changes

jerowe added 2 commits February 15, 2017 08:44

adding in license files

c161146

adding license to easybuild

96f09e1

typo

fe74af3

adding in license file directly form repo

da788fd

scopatz merged commit c82e991 into conda-forge:master Feb 15, 2017

boegel reviewed Feb 15, 2017

View reviewed changes

Uh oh!

Add easybuild recipes to conda #2391

Add easybuild recipes to conda #2391

Uh oh!

Conversation

jerowe commented Feb 9, 2017

Uh oh!

conda-forge-linter commented Feb 9, 2017

Uh oh!

conda-forge-linter commented Feb 9, 2017

Uh oh!

rmax commented Feb 9, 2017

Uh oh!

jerowe commented Feb 9, 2017

Uh oh!

conda-forge-linter commented Feb 9, 2017

Uh oh!

jerowe commented Feb 9, 2017

Uh oh!

jerowe commented Feb 9, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jerowe commented Feb 9, 2017

Uh oh!

jakirkham commented Feb 10, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jakirkham commented Feb 10, 2017

Uh oh!

jerowe commented Feb 10, 2017

Uh oh!

conda-forge-linter commented Feb 10, 2017

Uh oh!

conda-forge-linter commented Feb 10, 2017

Uh oh!

jakirkham commented Feb 12, 2017

Uh oh!

jerowe commented Feb 13, 2017

Uh oh!

scopatz commented Feb 13, 2017

Uh oh!

jerowe commented Feb 14, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

conda-forge-linter commented Feb 15, 2017