Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Feedback and maintainers welcome. |
jakirkham
force-pushed
the
add_cotire
branch
3 times, most recently
from
dd39512 to
96f4e62
Compare
|
Looks useful. I probably don't need to be a maintainer, but I'll back you up if you want. The recipe looks fine to me - as long as the CIs come back OK. |
recipes/cotire/meta.yaml
Outdated
| number: 0 | ||
| script: | ||
| - cp "${SRC_DIR}/CMake/cotire.cmake" "${PREFIX}"/share/cmake*/Modules # [unix] | ||
| - copy "%SRC_DIR%\\CMake\\cotire.cmake" "%LIBRARY_PREFIX%"\\share\\cmake*\\Modules # [win] |
There was a problem hiding this comment.
Am I doing something wrong here, @msarahan? It seem to have issues copying this on Windows. I really don't know the batch syntax.
There was a problem hiding this comment.
Maybe the quotes are causing this issues. Will try dropping them.
|
No worries. I'm guessing others might get excited about this. For the most part, maintaining this is mind-numbingly simple so I'm hoping its just not a big deal. |
jakirkham
force-pushed
the
add_cotire
branch
2 times, most recently
from
6e965ba to
96fd7d9
Compare
recipes/cotire/meta.yaml
Outdated
| commands: | ||
| # Verify that the cotire CMake file is in place. | ||
| - test -f "${PREFIX}"/share/cmake*/Modules/cotire.cmake # [unix] | ||
| - if not exist %LIBRARY_PREFIX%\\share\\cmake*\\Modules\\cotire.cmake exit 1 # [win] |
There was a problem hiding this comment.
Ugh...Windows doesn't like the wildcard here. Any suggestions?
There was a problem hiding this comment.
NVM guess I can cd here too.
jakirkham
force-pushed
the
add_cotire
branch
3 times, most recently
from
6d21e75 to
67cd95e
Compare
| - cmake -G "Unix Makefiles" .. # [unix] | ||
| - cmake -G "NMake Makefiles" .. # [win] | ||
| # Cannot find `cl` on Windows during tests. | ||
| - cmake --build . # [unix] |
There was a problem hiding this comment.
Have to skip on Windows. See this issue ( conda/conda-build#1059 ).
| # https://github.com/conda/conda-build/issues/1059 | ||
| # | ||
| #- cmake -G "NMake Makefiles" .. # [win] | ||
| - cmake --build . # [unix] |
There was a problem hiding this comment.
Had to skip building on Windows. Would be a nice test to include on all platforms, but it seems a bit challenging to get Windows to work. See this issue ( conda/conda-build#1059 ).
|
This is now passing. 😄 |
|
Awesome. Shame about the Windows testing bug. Anyway, LGTM! |
|
Nice, I think this kind of things tends to be included in projects though rather than used as an optional client library. At least that's what we did for openturns. Or maybe your approcah is to patch the target package yourself to use cotire ? |
|
Yeah, I figured it might make it easier for people to play with. Also, this way it can be versioned separately, which should reduce some maintenance burden on devs (or that was my thinking at least). |
6 participants
Adds a recipe for
cotire(written from scratch). This is useful for getting a unity build up and running quickly. May be useful to have this around for some of our longer builds.cc @jschueller @frol @ivoflipse @Korijn @patricksnape