Make conda’s package directories configurable#328
Merged
jaimergp merged 12 commits intoconda-incubator:mainfrom Oct 30, 2024
Merged
Make conda’s package directories configurable#328jaimergp merged 12 commits intoconda-incubator:mainfrom
jaimergp merged 12 commits intoconda-incubator:mainfrom
Conversation
This adds the ability to use D: on Windows runners, to increase speed of decompression.
goanpeca
reviewed
Dec 8, 2023
goanpeca
reviewed
Dec 8, 2023
goanpeca
reviewed
Dec 8, 2023
Member
|
Thanks for this work @jezdez ! Left a couple of minor comments 🚀 |
3 tasks
jaimergp
reviewed
Dec 11, 2023
kenodegard
reviewed
Dec 18, 2023
kenodegard
reviewed
Dec 18, 2023
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com> Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Member
Author
|
@conda-incubator/setup-miniconda any takers for another review? |
Member
|
Code looks good! Are there any issues with cross-drive hardlinking? I think Windows doesn't like creating those junctions over different units (or if the underlying drive is different), so maybe this is ends up becoming a performance hit if the env is not in the same drive. So, I wonder if:
|
Member
Author
|
@jaimergp I don't have answers for this at the moment |
Member
Author
|
I don't know why npm is adding all that cruft to dist/delete/index.js :( |
Member
Afaik the reason is: every new function used from a dependency is copied into the index.js ( |
jaimergp
approved these changes
Oct 30, 2024
jaimergp
changed the title
jezdez
added a commit
to jaimergp/conda-build
that referenced
this pull request
Nov 11, 2024
Now that conda-incubator/setup-miniconda#328 is merged.
jezdez
added a commit
to conda/conda
that referenced
this pull request
Nov 12, 2024
- use cross-platform compatible cache on GHA Windows runners - Use separate volume for high restore and save speed Xrefs conda-incubator/setup-miniconda#328 and conda/conda-build#5082
jezdez
added a commit
to conda/conda
that referenced
this pull request
Nov 12, 2024
- Use cross-platform compatible cache on GHA Windows runners - Use separate volume for high restore and save speed Xrefs conda-incubator/setup-miniconda#328 and conda/conda-build#5082
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to use
D:instead ofC:on GitHub hosted Windows runners, to increase the speed of decompression.See conda/conda-build#5082 (comment) for more information.