Fix double channel config apply and add initial testing#465
Merged
goanpeca merged 1 commit intoconda-incubator:mainfrom Mar 18, 2026
Merged
Fix double channel config apply and add initial testing#465goanpeca merged 1 commit intoconda-incubator:mainfrom
goanpeca merged 1 commit intoconda-incubator:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes issue #57 where conda channels were being added twice (once during initial config and again after tool installation), producing spurious warnings. Also introduces vitest for unit testing with a CI workflow.
Changes:
- Added a
reapplyparameter toapplyCondaConfigurationto skip channels/pkgs_dirs on the second call, preventing duplicate config warnings - Added vitest unit tests covering the new reapply behavior
- Added CI workflow for running tests, bumped several dependency versions
Reviewed changes
Copilot reviewed 8 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/conda.ts | Added reapply flag to skip channels/pkgs_dirs on re-application |
| src/base-tools/index.ts | Passes reapply=true to the second config call |
| src/tests/conda.test.ts | New unit tests for the reapply behavior |
| vitest.config.ts | Vitest configuration with coverage thresholds |
| package.json | Added vitest, bumped dependencies |
| .github/workflows/tests.yml | New CI workflow for unit tests |
| CLAUDE.md | New project documentation |
| tsconfig.json | Added node types, excluded vitest config |
| tsconfig.eslint.json | Included vitest config for linting |
| .gitignore | Added coverage directory |
| package-lock.json | Updated lockfile |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
goanpeca
changed the title
goanpeca
force-pushed
the
fix-double-config-apply
branch
2 times, most recently
from
11fec2c to
9212116
Compare
goanpeca
force-pushed
the
fix-double-config-apply
branch
from
9212116 to
7fc0a85
Compare
jezdez
approved these changes
Mar 17, 2026
jezdez
added a commit
to conda/conda
that referenced
this pull request
Apr 16, 2026
Follow-up to #15741. The original experimental branch in conda-incubator/setup-miniconda#453 has been closed and split into several non-breaking PRs that have now been merged to conda-incubator/setup-miniconda@main. This pins the action to the current main tip (a89f5d4) to measure the combined CI impact, including: - conda-incubator/setup-miniconda#465 fix double channel config apply - conda-incubator/setup-miniconda#467 bulk-move extracted pkgs on cleanup - conda-incubator/setup-miniconda#475 split shell init and activation - conda-incubator/setup-miniconda#482 channel parsing / URL validation - conda-incubator/setup-miniconda#486 remove HTML index scraping - conda-incubator/setup-miniconda#487 parallelize Windows takeown calls
3 tasks
kenodegard
pushed a commit
to conda/conda
that referenced
this pull request
Apr 23, 2026
conda-incubator/setup-miniconda@v4.0.0 ships a number of performance improvements: - conda-incubator/setup-miniconda#465 fix double channel config apply - conda-incubator/setup-miniconda#467 bulk-move extracted pkgs on cleanup - conda-incubator/setup-miniconda#475 split shell init and activation - conda-incubator/setup-miniconda#482 channel parsing / URL validation - conda-incubator/setup-miniconda#486 remove HTML index scraping - conda-incubator/setup-miniconda#487 parallelize Windows takeown calls - conda-incubator/setup-miniconda#488 replace isDefaultEnvironment subprocess with local YAML reads - conda-incubator/setup-miniconda#489 replace conda config subprocesses with direct .condarc YAML writes v4.0.0 also upgrades the action runtime to Node.js 24.x and switches the build to ESM, which is the breaking change motivating the major bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57
This PR also adds (finally) initial testing with vitest and ci workflow to run them :)