Skip to content

expand dso allow list for C:\Windows\** pattern possibly broken #5926

@wolfv

Description

@wolfv

Checklist

  • I added a descriptive title
  • I searched open reports and couldn't find a duplicate

What happened?

Looking at this code:

https://github.com/conda/conda-build/blob/f3854cdf42beb65dcb3bd5c03b641c1ca66e1b47/conda_build/post.py#L858C5-L890

It looks like _expand_dsoallowlist is called for this:

result["allow"].extend(_expand_dsolist(["C:/Windows/System32/**/*.dll"]))

However the code checks "startswith("*")" to check for globs. This will result in pretty weird "expansion" if I read the code properly.

Conda Info

Conda Config

Conda list

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    type::bugdescribes erroneous operation, use severity::* to classify the type

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions