Skip to content

Match build strings with globs#5600

Merged
beckermr merged 14 commits intoconda:mainfrom
jaimergp:match-build-strings-glob
Feb 19, 2025
Merged

Match build strings with globs#5600
beckermr merged 14 commits intoconda:mainfrom
jaimergp:match-build-strings-glob

Conversation

@jaimergp
Copy link
Copy Markdown
Member

@jaimergp jaimergp commented Jan 25, 2025

Description

See #5571 (comment)

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 25, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jan 25, 2025

CodSpeed Performance Report

Merging #5600 will not alter performance

Comparing jaimergp:match-build-strings-glob (e576ee6) with main (5413773)

Summary

✅ 5 untouched benchmarks

@beckermr
Copy link
Copy Markdown
Contributor

@jaimergp can we use the latest blas/blis failure from @h-vetinari to add a test here?

@jaimergp
Copy link
Copy Markdown
Member Author

Added.

@jaimergp
Copy link
Copy Markdown
Member Author

jaimergp commented Feb 4, 2025

Windows CI errors are unrelated and caused by mamba-org/mamba#3730.

@beckermr
Copy link
Copy Markdown
Contributor

beckermr commented Feb 4, 2025

I'm happy to merge this as is, but am waiting on you @jaimergp. Any blockers or should we go ahead?

@jaimergp
Copy link
Copy Markdown
Member Author

Any blockers or should we go ahead?

Those macos failures are odd :/

@beckermr
Copy link
Copy Markdown
Contributor

pre-commit.ci autofix

1 similar comment
@beckermr
Copy link
Copy Markdown
Contributor

pre-commit.ci autofix

@beckermr
Copy link
Copy Markdown
Contributor

@jaimergp looks like the retries I added fixed this for now...

@jaimergp jaimergp marked this pull request as ready for review February 18, 2025 20:21
@jaimergp jaimergp requested a review from a team as a code owner February 18, 2025 20:21
@jaimergp
Copy link
Copy Markdown
Member Author

Awesome! Thank you so much. This is then ready.

@beckermr beckermr merged commit 9eead20 into conda:main Feb 19, 2025
@kenodegard kenodegard mentioned this pull request Mar 17, 2025
59 tasks
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Feb 20, 2026
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants