Skip to content

test: use flaky decorator for flaky OSX/Win tests#5623

Merged
beckermr merged 7 commits intomainfrom
flaky-tests
Feb 16, 2025
Merged

test: use flaky decorator for flaky OSX/Win tests#5623
beckermr merged 7 commits intomainfrom
flaky-tests

Conversation

@beckermr
Copy link
Copy Markdown
Contributor

@beckermr beckermr commented Feb 16, 2025

Description

This PR adds the flaky mark to some OSX/Win tests that fail at random. I am hoping it helps the test suite pass on the first try since retrying jobs takes a long time.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Feb 16, 2025
@beckermr
Copy link
Copy Markdown
Contributor Author

pre-commit.ci autofix

@beckermr beckermr changed the title test: use flaky decorator for flaky tests test: use flaky decorator for flaky OSX tests Feb 16, 2025
Comment thread news/5623-flaky-tests.rst Outdated
@beckermr beckermr marked this pull request as ready for review February 16, 2025 13:19
@beckermr beckermr requested a review from a team as a code owner February 16, 2025 13:19
@beckermr
Copy link
Copy Markdown
Contributor Author

beckermr commented Feb 16, 2025

@jaimergp can you take a look at this one?

Hopefully it solves the random OSX/Win failures we've been seeing on recent PRs by simply retrying them.

@beckermr beckermr changed the title test: use flaky decorator for flaky OSX tests test: use flaky decorator for flaky OSX/Win tests Feb 16, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 16, 2025

CodSpeed Performance Report

Merging #5623 will not alter performance

Comparing flaky-tests (b1b5034) with main (7ad0e04)

Summary

✅ 5 untouched benchmarks

@beckermr
Copy link
Copy Markdown
Contributor Author

I've rerun the tests several times to try and trigger any other random failures. I did not find any, so this PR is ready to go!

@beckermr beckermr merged commit 5413773 into main Feb 16, 2025
@beckermr beckermr deleted the flaky-tests branch February 16, 2025 21:03
@beckermr
Copy link
Copy Markdown
Contributor Author

thanks @isuruf!

@kenodegard kenodegard mentioned this pull request Mar 17, 2025
59 tasks
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Feb 17, 2026
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants