Skip to content

Do not reinject extra_specs in solved specs#5646

Closed
jaimergp wants to merge 1 commit intoconda:mainfrom
jaimergp:version-invalidspec
Closed

Do not reinject extra_specs in solved specs#5646
jaimergp wants to merge 1 commit intoconda:mainfrom
jaimergp:version-invalidspec

Conversation

@jaimergp
Copy link
Copy Markdown
Member

Description

Closes #5644

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@github-project-automation github-project-automation Bot moved this to 🆕 New in 🔎 Review Mar 20, 2025
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 20, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 21, 2025

CodSpeed Performance Report

Merging #5646 will not alter performance

Comparing jaimergp:version-invalidspec (a0f8b6e) with main (834448b)

Summary

✅ 5 untouched benchmarks

@h-vetinari
Copy link
Copy Markdown
Contributor

h-vetinari commented Mar 21, 2025

Confirmed in conda-forge/pytorch-cpu-feedstock#378 that this fixes #5644 - thank you so much for the lightning-fast handling! 🙏

@beckermr
Copy link
Copy Markdown
Contributor

We should add an explicit test ensuring the PyTorch recipe builds. We can of course remove the actual build steps and replace them with stubs or something.

@jaimergp
Copy link
Copy Markdown
Member Author

Looks like @isuruf is reworking the whole PR at #5651, which includes this fix, so closing this one.

@jaimergp jaimergp closed this Mar 24, 2025
@github-project-automation github-project-automation Bot moved this from 🆕 New to 🏁 Done in 🔎 Review Mar 24, 2025
@github-actions github-actions Bot added the locked [bot] locked due to inactivity label Mar 25, 2026
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Regression: spurious InvalidVersionSpec on previously working constraint

4 participants