fix: skip mkdir ~/.conda when register_envs is false#1215
Merged
Conversation
The unconditional mkdir ~/.conda at the top of the base-environment install section fails under read-only $HOME. Installers that disable env registration do not need ~/.conda/environments.txt, so gate the mkdir on register_envs being true.
conda-bot
added
the
cla-signed
chrisburr
marked this pull request as ready for review
April 15, 2026 07:31
chrisburr
marked this pull request as draft
April 15, 2026 08:12
chrisburr
marked this pull request as draft
April 15, 2026 08:12
chrisburr
force-pushed
the
fix/mkdir-conda-guard
branch
2 times, most recently
from
April 15, 2026 09:28
35a8966 to
20bf60d
Compare
chrisburr
marked this pull request as ready for review
April 15, 2026 09:28
lrandersson
approved these changes
Apr 15, 2026
Contributor
There was a problem hiding this comment.
Thanks for working on this, I think it looks good! I'll let @marcoesters have the final word in case there is something that I might have missed.
marcoesters
approved these changes
Apr 15, 2026
Contributor
Author
|
Thanks for the prompt review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In DIRACGrid/DIRACOS2#174 we saw that the unconditional
mkdir ~/.condaat the top of the base-environment install section fails under read-only$HOME. As this installer disables env registration it does not need~/.conda/, so gate themkdironregister_envsbeingtrue.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?