Skip to content

Drop Jinja name from PyPI URL (using f-string instead) #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakirkham wants to merge 2 commits into from
Closed

Drop Jinja name from PyPI URL (using f-string instead) #548

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d037674
Change PyPI URL Jinja to f-string
jakirkham Aug 13, 2024
423a8a5
Merge branch 'main' into drop_url_name_jinja
marcelotrevisani Aug 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion grayskull/strategy/pypi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ def get_pypi_metadata(config: Configuration) -> dict:
"url": info.get("home_page"),
"license": info.get("license"),
"source": {
"url": config.url_pypi + "/packages/source/{{ name[0] }}/{{ name }}/"
"url": config.url_pypi + f"/packages/source/{config.name[0]}/{config.name}/"
Copy link

@bollwyvl bollwyvl Aug 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will always be normalized (even for historic builds), with the most-widely used implementation being packaging.utils.canonicalize_name.

Copy link
Member

@marcelotrevisani marcelotrevisani Aug 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is a good idea, grayskull still tries to canonicalize the names, but having that implementation to use out of the box might be better indeed

Copy link
Member Author

@jakirkham jakirkham Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be stored as a key for reuse?

f"{get_url_filename(metadata)}",
"sha256": get_sha256_from_pypi_metadata(metadata),
},
Expand Down