Skip to content

Also expand parameters in lists of strings #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hmaarrfk wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −7
Open

Also expand parameters in lists of strings #333

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8a36bc
Also expand parameters in lists of strings
hmaarrfk May 17, 2025
dbd9d7d
Update menuinst/platforms/base.py
hmaarrfk Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions menuinst/platforms/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,17 +50,26 @@ def remove(self) -> List[Path]:
raise NotImplementedError

def render(self, value: Any, slug: bool = False, extra: Dict = None) -> Any:
if not hasattr(value, "replace"):
return value
is_list = isinstance(value, list)
if not is_list:
value = [value]
if extra:
placeholders = {**self.placeholders, **extra}
else:
placeholders = self.placeholders
for placeholder, replacement in placeholders.items():
value = value.replace("{{ " + placeholder + " }}", replacement)
if slug:
value = slugify(value)
return value

final_values = []
for v in value:
if hasattr(v, "replace"):
for placeholder, replacement in placeholders.items():
v = v.replace("{{ " + placeholder + " }}", replacement)
if slug:
v = slugify(v)
final_values.append(v)
if not is_list:
return final_values[0]
else:
return final_values

@property
def placeholders(self) -> Dict[str, str]:
Expand Down