Repository navigation
perf: compile simple glob patterns into string matcher variants - #2924
Merged
Merged
Conversation
Contributor
|
Details |
baszalmstra
marked this pull request as ready for review
October 9, 2026 11:23
wolfv
approved these changes
Oct 12, 2026
This was referenced Oct 12, 2026
Closed
Merged
Merged
1 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Compile simple globs into
Any,Prefix, andSuffixvariants instead of checking the pattern on every match. Complex patterns still useGlob. Adding variants breaks exhaustive matches.Local paired benchmarks on eight build strings took 78–79% less time for prefixes and 89–91% less for suffixes than the general glob matcher. These are matcher timings, not full-solve gains.
How Has This Been Tested?
430 conda-type tests and 110 solver tests passed, including glob parity and canonical/JSON roundtrips. Cargo fmt and Clippy passed. Benchmarks used resolvo 0.12.2.
AI Disclosure
Tools: Codex
Checklist: