Repository navigation
test(gateway): Fix progress bar being redrawn after child is spawned - #2969
Merged
pavelzw merged 2 commits intoOct 20, 2026
Merged
Conversation
…lation A download reporter gets on_download_start but never on_download_complete when a shard or shard index request fails or the fetch is cancelled. Consumers that track in-flight downloads, such as pixi's repodata progress bar, then keep them alive forever. These tests fail until that is fixed.
…elled Every repodata fetch reported on_download_start but only reported on_download_complete on success. A failed request, an error status or a cancelled future left the download in progress forever, and a progress bar tracking it never finished. Move the drop guard that run_exports_extractor already used into the reporter module and use it for every repodata, shard, shard index and channel notice download. Successful downloads still report completion under the response url right after the body is read.
pavelzw
approved these changes
Oct 20, 2026
I-Al-Istannen
marked this pull request as ready for review
October 20, 2026 09:48
This was referenced Oct 20, 2026
Closed
Merged
Merged
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using
pixi execthe progress bar indicating repodata download progress might continue being drawn and refreshed over the child process it executes. This leads to flickering layout in TUIs which self-heal and annoying spam in CLI programs that do not use a TUI. See, for example:How Has This Been Tested?
Unit tests I added that previously failed, the error sadly is non-deterministic and relies on external services to occur.
AI Disclosure
Tools: Claude Code
Checklist: