Repository navigation
chore: bump opendal to 0.59 - #2979
Merged
Merged
Conversation
opendal 0.57 depends on quick-xml 0.39, which has two DoS advisories (RUSTSEC-2026-0194, RUSTSEC-2026-0195); 0.59 uses quick-xml 0.42. - Operator::new returns the Operator directly, so drop .finish(). - Port the ETag memory test backend from the removed raw Access trait to Service: read/write/list/delete are now synchronous, so conditional read checks move into a StreamReader, the writer takes the entry lock and checks write conditions on its first write/close, and the lister collects entries on its first next(). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
4 tasks done
opendal 0.59 no longer installs an HTTP transport, so every S3 request failed with "default HTTP transport is not installed". Rather than installing one process-wide from library code (first-installed-wins, which would take the choice away from applications), add S3CredentialSource::opendal_operator, which attaches a reqwest transport to the operator it builds, and use it in rattler_index and rattler_upload. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
pavelzw
approved these changes
Oct 23, 2026
Merged
wolfv
added a commit
that referenced
this pull request
Oct 23, 2026
sigstore 0.15 (#2977) and opendal 0.59 (#2979) change types that are part of the public API of these crates. cargo-semver-checks doesn't flag dependency type changes like these, so bump by hand: - rattler_sigstore 0.3.0: re-exports sigstore types - rattler 0.55.0: Installer::with_attestation_policy takes a rattler_sigstore VerificationPolicy - rattler_virtual_package_detectors 0.3.0: EnvironmentError::Install wraps rattler's InstallerError - rattler_s3 0.4.0: opendal_builder returns an opendal S3 builder - rattler_index 0.34.0: takes opendal Operators, exposes an opendal Timestamp - rattler_upload 0.14.0: S3Opts::credentials is a rattler_s3 type The zip 9 baselines are published (rattler_package_streaming 0.27.15), so turn semver_check back on. Exclude the release-plz generated crate changelogs from typos, since they quote old commit messages verbatim. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
opendal 0.57 pulls in
quick-xml0.39.4, which has two DoS advisories (RUSTSEC-2026-0194, RUSTSEC-2026-0195). opendal 0.59 usesquick-xml0.42. I split this out of #2977 because of the raw API rewrite below.The library side needs two changes:
Operator::newnow returns theOperator, so.finish()goes away (rattler_index,rattler_upload).default HTTP transport is not installed.opendal::install_default()would fix that, but it installs the transport process-wide on a first-installed-wins basis, and a library shouldn't make that choice for the application. Instead, the newS3CredentialSource::opendal_operator()inrattler_s3builds the operator and attaches its ownreqwesttransport (opendal-http-transport-reqwest).rattler_indexandrattler_uploadnow use it instead ofopendal_builder()+Operator::new.Most of the diff is the ETag memory backend in the
rattler_indextests. opendal 0.59 replaced the rawAccesstrait withService, andread/write/list/deleteare now synchronous and take anOperationContext. What moved:oio::StreamReader. Itsopen()does whatread()used to do (hooks,if_match/if_none_match/if_unmodified_since), and it also honors the requested byte range.write()orclose(). TheBeforeWritehook fires at that point too. The lock is still held untilclose(), so concurrent writes to one path are serialized the same way as before.next(). The listing logic itself didn't change; I only moved it intoETagMemoryBackend::list_entries.MetadataBuilder(FileEntry::metadata()).The backend changes are in test code only. Nothing changes for users apart from the newer opendal.
How Has This Been Tested?
cargo nextest run -p rattler_index -p rattler_upload -p rattler_s3 --all-features: 85/85 pass, the same 85 tests thatmainlists.if_matchcheck on writes in the backend.test_conditional_write_with_if_matchfails both here and onmain, and nothing else does on either, so the coverage is unchanged. (The concurrency tests don't depend on that particular check, before or after.)pixi run e2e-s3-rustfspasses locally (upload, index, cache-control headers, install). That's the test that caught the missing transport, which the unit tests can't see because they only use the memory and fs backends.cargo checkpasses inpy-rattler/, andcargo auditno longer reportsquick-xml.AI Disclosure
Tools: Claude Code
Checklist:
🤖 Generated with Claude Code