Misc fixes #1
Merged
Misc fixes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatically detects and uses imagePullSecrets from the default service account when not explicitly defined in the manifest. This supports the common Kubernetes pattern of configuring registry credentials at the service account level instead of per-pod. Co-Authored-By: Claude <[email protected]> Signed-off-by: Pradipta Banerjee <[email protected]>
- Add deployment-with-secrets-and-imagepullsecrets.yaml test fixture - Add comprehensive test for Deployment with secrets and imagePullSecrets - Fix manifest methods to use GetPodSpec() instead of GetSpec() for proper handling of Deployment, StatefulSet, DaemonSet, and other workload resources - Methods updated: GetSecretRefs, ReplaceSecretName, AddVolume, AddInitContainer, GetInitContainers, AddVolumeMountToContainer, GetRuntimeClass, ConvertEnvSecretToSealed, ConvertVolumeSecretToInitContainer, RemoveSecretVolume, ConvertEnvFromSecret - All tests passing Signed-off-by: Pradipta Banerjee <[email protected]>
- Add replicaset-with-secrets-and-imagepullsecrets.yaml test fixture - Add comprehensive test for ReplicaSet with secrets and imagePullSecrets - Verifies GetPodSpec, GetImagePullSecrets, GetSecretRefs, and SetRuntimeClass work correctly for ReplicaSet resources Signed-off-by: Pradipta Banerjee <[email protected]>
- Add statefulset-with-secrets-and-imagepullsecrets.yaml test fixture - Add comprehensive test for StatefulSet with secrets and imagePullSecrets - Verifies GetPodSpec, GetImagePullSecrets, GetSecretRefs, and SetRuntimeClass work correctly for StatefulSet resources Signed-off-by: Pradipta Banerjee <[email protected]>
- Add job-with-secrets-and-imagepullsecrets.yaml test fixture - Add comprehensive test for Job with secrets and imagePullSecrets - Verifies GetPodSpec, GetImagePullSecrets, GetSecretRefs, and SetRuntimeClass work correctly for Job resources Signed-off-by: Pradipta Banerjee <[email protected]>
initdata annotation must be placed on pod template metadata for workload resources (Deployment, StatefulSet, ReplicaSet, Job, DaemonSet), not on the resource's top-level metadata. Fix the tests as well Signed-off-by: Pradipta Banerjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.