Multi yaml support #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trustee KBS only handles dockerconfigjson format. This change automatically detects and converts legacy .dockercfg format imagePullSecrets to the newer .dockerconfigjson format before uploading to Trustee. The conversion wraps registry credentials in an "auths" object while preserving all authentication data and email fields. The converted key is stored as dockerconfigjson in KBS and referenced correctly in initdata. Co-Authored-By: Claude <[email protected]> Signed-off-by: Pradipta Banerjee <[email protected]>
This commit implements automatic --sidecar-port-forward detection from Service manifests in multi-document YAML files. The implementation includes named port resolution by inspecting container ports. Key features: - Multi-document YAML parsing with LoadMultiDocument() - Service targetPort extraction (numeric and named ports) - Named port resolution by searching container ports - Automatic port detection when --sidecar is enabled - Conflict detection for sidecar HTTPS port (8443) - Backward compatible with single-document manifests Co-Authored-By: Claude <[email protected]> Signed-off-by: Pradipta Banerjee <[email protected]>
Added 6 test cases for the real-world vLLM deployment manifest that includes a headless Service and complex Deployment with probes, volumes, and resource limits. These tests validate: 1. Service-before-Deployment ordering (GetPrimaryManifest correctness) 2. Named port resolution (targetPort: http -> containerPort: 8000) 3. Headless service support (clusterIP: None) 4. Complex deployment structure handling 5. Existing runtimeClassName preservation 6. Existing annotations preservation Test cases: - TestManifestSet_vLLM_ServiceBeforeDeployment - TestManifestSet_vLLM_NamedPortResolution - TestManifestSet_vLLM_HeadlessService - TestManifestSet_vLLM_ComplexDeployment - TestManifestSet_vLLM_ExistingRuntimeClass - TestManifestSet_vLLM_ExistingAnnotations Co-Authored-By: Claude <[email protected]> Signed-off-by: Pradipta Banerjee <[email protected]>
The type name ManifestSet stutters with the package name manifest. Following Go naming conventions, renamed to manifest.Set. Co-Authored-By: Claude <[email protected]> Signed-off-by: Pradipta Banerjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.