This repository was archived by the owner on Feb 13, 2025. It is now read-only.
feat: Packet-level filtering#275
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 2835b3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
webmaster128
left a comment
webmaster128
left a comment
Member
There was a problem hiding this comment.
Filtering looks good to me, just the newline
clockworkgr
force-pushed
the
feat/packet-filtering
branch
from
82371e8 to
9075249
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the option to only relay specific packets that are of interest to the app developer.
In order to avoid unnecessary development and maintenance overhead, the filtering mechanism is left entirely to the app developer.
This is achieved by defining a new function type:
PacketFilterthat takes aPacketas an argument and returnstrueif it should be relayed andfalseif it should be ignored.Implementation of this function is left to the application developer and can be used by setting it via
link.setFilter(packetFilter: PacketFilter)on theLinkinstance.This PR also includes the complementary
Link.clearFilter()method.