fetchTopicOffsetsByTimestamp api implemented #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
milindl
requested changes
Dec 16, 2024
Contributor
milindl
left a comment
milindl
left a comment
There was a problem hiding this comment.
Thanks!
Some changes suggested.
Also update the changelog and the readme
test/promisified/admin/fetch_topic_offsets_by_timestamp.spec.js
Outdated
Show resolved
Hide resolved
test/promisified/admin/fetch_topic_offsets_by_timestamp.spec.js
Outdated
Show resolved
Hide resolved
milindl
reviewed
Dec 17, 2024
Contributor
milindl
left a comment
milindl
left a comment
There was a problem hiding this comment.
As a part of this PR, add
@memberof RdKafka
Within admin.js, for the comment for the function OffsetSpec
CHANGELOG.md
Outdated
| 2. Add support for Node v23 pre-built binaries (#158). | ||
| 3. Add KafkaJS-compatible errors to promisified Admin API (createTopics, deleteGroups, deleteTopicRecords) (#159). | ||
| 4. Include error types within Type definitions for promisified API (#210). | ||
| 5. Add support for an Admin API to fetch topic offsets by timestamp (#206). |
Contributor
There was a problem hiding this comment.
Move to changelog for 1.1.0 as discussed
| }, | ||
| ]); | ||
|
|
||
| const offsetsAtSpecificTimestamp2 = await admin.fetchTopicOffsetsByTimestamp(topicName, now + 150); |
Contributor
There was a problem hiding this comment.
Suggested change
| const offsetsAtSpecificTimestamp2 = await admin.fetchTopicOffsetsByTimestamp(topicName, now + 150); | |
| const offsetsAtSpecificTimestamp2 = await admin.fetchTopicOffsetsByTimestamp(topicName, now + 250); |
(tests the 'equal' case)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented fetchTopicOffsetsByTimestamp for kafkajs and wrote tests and example for it