Map HTTP/2 RST_STREAM codes back to RPC codes #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP/2 includes its own set of error codes, which are sent in RST_STREAM frames. When servers send one of these codes to clients, we should map the HTTP/2 code back to one of our status codes.
|
The string munging to extract HTTP/2 error codes is quite unpleasant; filed golang/go#53896 to see if the Go team has any interest in making this a bit cleaner. |
pkwarren
approved these changes
Jul 15, 2022
error.go
Outdated
| } | ||
| msg = strings.TrimSuffix(msg, fromPeerSuffix) | ||
| i := strings.LastIndex(msg, ";") | ||
| if i < 0 || i == len(msg) { |
There was a problem hiding this comment.
Suggested change
| if i < 0 || i == len(msg) { | |
| if i < 0 { |
I don't think LastIndex will return len(msg) - I think it will be in range 0:len(msg)-1 if found.
There was a problem hiding this comment.
Off by one error on my part, thank you for catching this! I meant to ensure that i < len(msg)-1, since we're slicing with [i+1] below.
pkwarren
approved these changes
Jul 15, 2022
akshayjshah
added a commit
that referenced
this pull request
Jul 26, 2023
HTTP/2 includes its own set of error codes, which are sent in RST_STREAM frames. When servers send one of these codes to clients, we should map the HTTP/2 code back to one of our status codes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP/2 includes its own set of error codes, which are sent in RST_STREAM
frames. When servers send one of these codes to clients, we should map
the HTTP/2 code back to one of our status codes.