Add features to work with no_std, and with alloc in no_std #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please include |
djc
approved these changes
Jun 6, 2025
|
I squashed and force pushed. |
|
Looks like the WASM situation needs a little work. Otherwise this is looking good! |
Always include std feature in make tests I would assume all of the tests require std since this crate originally was std only Add clippy warnings to always use `core` and `alloc` instead of `std` Fix clippy by replacing std with core and alloc when possible Some changes Add --lib when testing without default features Make windows and wasm modules require std feature.
|
I made wasm and windows require the "std" feature now so it should work. |
djc
approved these changes
Jun 13, 2025
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #255
3 levels:
no_std without alloc: some stuff works
no_std with alloc: some more stuff works
std: everything works
Tested by using
console::strip_ansi_codesin my OS, onx86_64-unknown-nonewith theallocfeature.