This repository was archived by the owner on Mar 6, 2020. It is now read-only.
cmd/gb-vendor: search $GOROOT/src/vendor when resolving recursive deps #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #635 golang/go#16333 renamed $GOROOT/src/vendor/golang.org to $GOROOT/src/vendor/golang_org. This solved a nasty problem where code in GOROOT would shadow any other copy of the net/http2 library, but meant that gb vendor could no longer resolve the package and try to fetch it (even if that was pointless). To solve this, include $GOROOT/src/vendor in the set of search paths so that golang_org/net/http/... is always found (if present). I'll add a test for this in the integration test repo.
$GOROOT/src/vendor does not exist in Go < 1.6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #635
golang/go#16333 renamed $GOROOT/src/vendor/golang.org to
$GOROOT/src/vendor/golang_org. This solved a nasty problem where code in
GOROOT would shadow any other copy of the net/http2 library, but meant
that gb vendor could no longer resolve the package and try to fetch it
(even if that was pointless).
To solve this, include $GOROOT/src/vendor in the set of search paths so
that golang_org/net/http/... is always found (if present).
I'll add a test for this in the integration test repo.