Skip to content

Remove Trailing Whitespace from the Spec #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

akutz
Copy link
Contributor

@akutz akutz commented Sep 20, 2017

This patch removes trailing whitespace from the CSI specification.

This patch removes trailing whitespace from the CSI specification.
@gpaul
Copy link

gpaul commented Sep 20, 2017

This is great. Do consider adding a 'strip whitespace' command to the Makefile build target and enforce the check in CI - otherwise it is just a matter of time until some nano user adds spaces again.

@akutz
Copy link
Contributor Author

akutz commented Sep 20, 2017

Hi @gpaul,

Good call. I know most of it was added by @jdef when he authored the documents, but I also know he uses Vim on, presumably, Linux. My attempts to edit them with Vim on macOS also strip the whitespace. It's when I surmised it was some default behavior based on OS/editor combination.

I'm not sure if you and @jdef accidentally type a trailing space before you go to a newline or if the OS/editor defaults to doing it automatically. I know I often default to leaving spaces before I hit return, and my editor just simply erases them for me.

I am also very picky about details and as a result my editor shows whitespace characters so it is obvious to me when I use spaces instead of tabs by pasting in some text, or when there is trailing whitespace at the end of a line or on an otherwise "empty" line.

Again though, it's not an Atom thing alone as vim on macOS also strips all these spaces. It's weird.

Copy link
Member

@jieyu jieyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akutz !

@jieyu jieyu merged commit d68da7a into container-storage-interface:master Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants