Skip to content

Fix ControllerPublish/Unpublish error codes #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix ControllerPublish/Unpublish error codes #146

wants to merge 2 commits into from

Conversation

jsafrane
Copy link
Contributor

  • ControllerUnpublishVolume must be idempotent and thus return no error instead of VOLUME_NOT_ATTACHED_TO_SPECIFIED_NODE
  • VOLUME_ALREADY_ATTACHED does not exists, use VOLUME_ALREADY_PUBLISHED instead.

@jsafrane
Remove VOLUME_NOT_ATTACHED_TO_SPECIFIED_NODE
6e718b1 
ControllerUnpublishVolume should be idempotent and thus return no error in this case.
@jsafrane
Rename VOLUME_ALREADY_ATTACHED to _PUBLISHED
50bd6ad
@jsafrane
Copy link
Contributor Author

BTW, a standard gRPC error codes as suggested in #115 would be much easier to use. Close this if #115 is merged.

@jsafrane
Copy link
Contributor Author

closing in favor of #115

@jsafrane jsafrane closed this Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jsafrane