-
Notifications
You must be signed in to change notification settings - Fork 378
Generating Go Bindings with Docker #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
akutz
wants to merge
1
commit into
container-storage-interface:master
from
akutz:feature/dockerfile-go
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
FROM golang:1.9.3 | ||
|
||
RUN apt-get update && apt-get install -y unzip | ||
|
||
RUN mkdir -p /csi | ||
WORKDIR /csi | ||
|
||
ENV PROTOC_VER 3.5.1 | ||
ENV PROTOC_ZIP protoc-$PROTOC_VER-linux-x86_64.zip | ||
ENV PROTOC_URL_PFX https://github.com/google/protobuf/releases/download | ||
ENV PROTOC_URL $PROTOC_URL_PFX/v$PROTOC_VER/$PROTOC_ZIP | ||
ENV PROTOC_BIN bin/protoc | ||
RUN curl -LO $PROTOC_URL && unzip $PROTOC_ZIP && chmod 0755 $PROTOC_BIN | ||
|
||
RUN go get -u github.com/golang/protobuf/protoc-gen-go | ||
|
||
COPY spec.md /csi | ||
|
||
RUN cat spec.md | \ | ||
sed -n -e '/```protobuf$/,/```$/ p' | \ | ||
sed -e 's@^```.*$@////////@g' > csi.proto | ||
|
||
RUN $PROTOC_BIN -I . --go_out=plugins=grpc:. csi.proto | ||
|
||
FROM alpine:3.7 | ||
RUN mkdir /csi | ||
WORKDIR /csi | ||
COPY --from=0 /csi/csi.pb.go . | ||
COPY --from=0 /csi/csi.proto . | ||
COPY --from=0 /csi/spec.md . | ||
|
||
CMD [ "csi.pb.go" ] | ||
ENTRYPOINT [ "cat" ] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit, you can name each stage with
FROM golang:1.9.3 AS build
and then useCOPY --from=build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cpuguy83,
Thanks! I've actually done that, but since this was a single stage being referenced I didn't care.