Add CONTRIBUTING.md for guidance on contributing #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieyu
force-pushed
the
contributing
branch
2 times, most recently
from
2b8e835 to
4857f66
Compare
saad-ali
reviewed
May 22, 2017
CONTRIBUTING.md
Outdated
|
|
||
| ## Git commit | ||
|
|
||
| ### Sign your work |
There was a problem hiding this comment.
Do we really want to enforce DCO or CLA?
There was a problem hiding this comment.
I removed this section for now as we figure out the details.
The initial guidance includes the markdown and git commit style. Signed-off-by: Jie Yu <[email protected]>
jdef
approved these changes
May 23, 2017
saad-ali
added a commit
to saad-ali/spec
that referenced
this pull request
Aug 18, 2017
Address CR Feedback to node multi call
saad-ali
added a commit
to saad-ali/spec
that referenced
this pull request
Aug 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial guidance includes the markdown and git commit style.