Skip to content

Add name field in DeleteVolumeRequest #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions csi.proto
Original file line number Diff line number Diff line change
Expand Up @@ -293,13 +293,27 @@ message DeleteVolumeRequest {
Version version = 1;

// The handle of the volume to be deprovisioned.
// This field is REQUIRED.
VolumeHandle volume_handle = 2;
// Either `name` or `volume_handle` SHALL be specified by the CO.
// A CO MAY specify the `name` when the `volume_handle` is unknown.
// For example, in the case where a `CreateVolume` RPC fails and the
// CO is unsure of the completion state of the request AND no longer
// needs the possibly-created volume. Alternatively, a CO MAY
// specify the `volume_handle` field when such information is
// available to it. This field is REQUIRED.
oneof handle {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not crazy about handle as the name for this oneof, but I can't think of anything better. using reference yields a weird golang API code. Naming .. ugh.

// The CO-generated name of the volume to delete, same as in
// `CreateVolumeRequest`.
string name = 2;

// The plugin-generated handle to the volume, as returned in
// `CreateVolumeResponse`.
VolumeHandle volume_handle = 3;
}

// End user credentials used to authenticate/authorize volume deletion
// request.
// This field is OPTIONAL.
Credentials user_credentials = 3;
Credentials user_credentials = 4;
}

message DeleteVolumeResponse {
Expand Down
Loading