CI: v2.1.0 binaries could not be released

[AkihiroSuda]

https://github.com/containerd/nerdctl/actions/runs/14968102709/job/42042591345

#59 [build-full 5/8] RUN /out/bin/gomodjail pack --go-mod=/go/src/github.com/containerd/nerdctl/go.mod /out/bin/nerdctl &&   cp -a nerdctl.gomodjail /out/bin/
#59 0.146 /out/bin/gomodjail: line 1: syntax error: unexpected ")"
#59 ERROR: process "/bin/sh -c /out/bin/gomodjail pack --go-mod=/go/src/github.com/containerd/nerdctl/go.mod /out/bin/nerdctl &&   cp -a nerdctl.gomodjail /out/bin/" did not complete successfully: exit code: 2
------
 > [build-full 5/8] RUN /out/bin/gomodjail pack --go-mod=/go/src/github.com/containerd/nerdctl/go.mod /out/bin/nerdctl &&   cp -a nerdctl.gomodjail /out/bin/:
0.146 /out/bin/gomodjail: line 1: syntax error: unexpected ")"
------
Dockerfile:257
--------------------
 256 |     RUN BINDIR=/out/bin make binaries install
 257 | >>> RUN /out/bin/gomodjail pack --go-mod=/go/src/github.com/containerd/nerdctl/go.mod /out/bin/nerdctl && \
 258 | >>>   cp -a nerdctl.gomodjail /out/bin/
 259 |     COPY README.md /out/share/doc/nerdctl/
--------------------
ERROR: failed to solve: process "/bin/sh -c /out/bin/gomodjail pack --go-mod=/go/src/github.com/containerd/nerdctl/go.mod /out/bin/nerdctl &&   cp -a nerdctl.gomodjail /out/bin/" did not complete successfully: exit code: 2
make: *** [Makefile:282: artifacts] Error 1

[AkihiroSuda]

Why wasn't this caught in https://github.com/containerd/nerdctl/blob/v2.1.0/.github/workflows/ghcr-image-build-and-publish.yml ?

(because it has extra setup-qemu-action?)

[apostasie]

What about we run the release task on PRs as well, but instead of gh-release we save the result as a github artifact?

Pros:

• ensure the release builder does work (this problem here would have been caught)
• allow people to easily access a release tarball from any PR (so they can test a feature in development without having to build themselves)

Cons:

• yet another pipeline to run on every CI run

I was/am reluctant to touch release scripts, because it is tricky to test and the risk is high to break it - but ironically, not touching it also has the same risks...

[AkihiroSuda]

SGTM

[fahedouch]

What about we run the release task on PRs as well, but instead of gh-release we save the result as a github artifact?

Pros:

ensure the release builder does work (this problem here would have been caught)
allow people to easily access a release tarball from any PR (so they can test a feature in development without having to build themselves)
Cons:

yet another pipeline to run on every CI run
I was/am reluctant to touch release scripts, because it is tricky to test and the risk is high to break it - but ironically, not touching it also has the same risks...

Can we make it optional/manually?

[apostasie]

What about we run the release task on PRs as well, but instead of gh-release we save the result as a github artifact?
Pros:
ensure the release builder does work (this problem here would have been caught)
allow people to easily access a release tarball from any PR (so they can test a feature in development without having to build themselves)
Cons:
yet another pipeline to run on every CI run
I was/am reluctant to touch release scripts, because it is tricky to test and the risk is high to break it - but ironically, not touching it also has the same risks...

Can we make it optional/manually?

I will do some exploration and offer options in a PR (will tag you @fahedouch).