podman_compose: fix in-pod argparse type #712
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If "bool" is provided as an argparse type it will only evaluate to false if an empty string is provided. This lambda attempts to resolve this by filtering for "1" or "true". Signed-off-by: Randolph Sapp <[email protected]>
|
Thanks for the PR. I rewrote this idea to be more complete and actually check that the passed value can be converted to bool (empty, The improved PR is this one #918. Thanks a lot for the suggested fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If "bool" is provided as an argparse type it will only evaluate to false if an empty string is provided. This lambda attempts to resolve this by filtering for "1" or "true".
I used a lambda here for backwards compatibility as argparse didn't add the
BooleanOptionalActionaction until 3.9 and you still advertise 3.7 compatibility in the README and setup.I was looking at a previous attempt to resolve this ( #546 ) and noticed it was NAK'd for not allowing auto selection but considering the systemd template that's currently present, auto selection is not possible and we seem to be making the assumption that the default value is true.
Maybe the arg should be dropped entirely? The stable release included that template with in-pod defaulting to False leading to fun behavior described in #695 . This is uncorrectable from the user side as the script calls itself with minimal args to create the container before registering it.