Skip to content

Provide instructions for linting on Windows #21911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
l0rd opened this issue Mar 1, 2024 · 2 comments
Closed

Provide instructions for linting on Windows #21911

l0rd opened this issue Mar 1, 2024 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. windows issue/bug on Windows

Comments

@l0rd
Copy link
Member

l0rd commented Mar 1, 2024 •
edited
Loading

Feature request description

make lint or winmake lint are both failing on windows currently so contributors don't know how to run the linter against the local changes before pushing a commit.

Suggest potential solution

It's possible to install golangci-lint on Windows (winget add -e GolangCI.golangci-lint ) but running it complains because diff is not found. To get diff we can then include Git for windows bin folder to PATH ($Env:Path += ";C:\Program Files\Git\usr\bin") but then some new errors are thrown...it will eventually work but it needs some more time.

Have you considered any alternatives?

We could provide instructions (or a new make target) to execute make lint in a container using podman run.

Additional context

Add any other context or screenshots about the feature request here.
@l0rd l0rd added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 1, 2024
@l0rd l0rd mentioned this issue Mar 1, 2024
Closed
@Luap99 Luap99 added the windows issue/bug on Windows label Mar 14, 2024
@github-actions GitHub Actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@l0rd l0rd removed the stale-issue label May 8, 2024
@l0rd l0rd mentioned this issue Jun 5, 2024
Merged
l0rd added a commit to l0rd/podman that referenced this issue Jun 6, 2024
@l0rd
Add new targets on Windows makefile (winmake.ps1)
dcec81e 
Add the following targets in winmake.ps1:
- `installer`: builds the Windows installer
- `docs`: builds the documentation HTML pages
- `validatepr`: runs the Linux Makefile `.valiatepr`
                target using podman.
- `lint`: faster validation that runs linter locally

Update of `build_windows.md`:
- removed every reference to the MSYS2 platform
- added instructions to build the installer and linters

Fix containers#21821 and containers#21911

Signed-off-by: Mario Loriedo <[email protected]>
@l0rd
Copy link
Member Author

l0rd commented Jul 10, 2024

This issue has been addressed by #22913

@l0rd l0rd closed this as completed Jul 10, 2024
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 9, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. windows issue/bug on Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@l0rd @Luap99