-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Update the Podman on Windows tutorial #27648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: l0rd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I did not look at the content and I am unqualified to review windows docs anyway but...
With the v5.7 release the v5.6 branch is dead and unsupported upstream so we won't do any further changes or releases there. |
| automatically installs WSL. If the Hyper-V feature is not enabled, you can | ||
| enable it by running | ||
| `Enable-WindowsOptionalFeature -Online -FeatureName Microsoft-Hyper-V -All` from | ||
| an administrator PowerShell prompt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iirc, users are directed to reboot with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0229c3f to
3d1fa3c
Compare
It was my understanding that some v5.6 specific updates to the tutorial would be useful for a podman desktop build. I don't know if that should land in the v5.6 branch on GitHub or somwher else. Anyway I have added a separate, v6.0 specific, commit so that we can still cherry-pick the v5.6 commit if needed. Or I can squash them too. cc @mheon. |
Ack, yeah my point is just we have an established release process and I don't want to make special case for things like this.
That is totally cool with me, we can also consider backporting this to v5.7 since that branch is active. |
1ae1849 to
9876bb0
Compare
|
@l0rd seems good - do you plan to add more info about hyperv usage (e.g. you must be admin when creating the first hyperv machine ... ) when we're done with the enhancements? |
|
Cockpit tests failed for commit 9876bb0. @martinpitt, @jelly, @mvollmer please check. |
9876bb0 to
9285aa0
Compare
Yes thank you. I have added a few sentences about it. Both on the 5.7 version (require admins privileges) and the 6.0 (requires admin privileges for first |
|
Cockpit tests failed for commit 9285aa0. @martinpitt, @jelly, @mvollmer please check. |
|
LGTM |
|
@containers/podman-maintainers PTAL and merge. I would like to cherry-pick the first commit of this PR to branch v5.7 (I have published the resulting article for ease of reading). |
| `winget install Microsoft.WindowsTerminal` | ||
|
|
||
|
|
||
| Installing Podman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just find it odd that we're documenting a version of Podman that won't be available for several months. I think it will be confusing to anyone trying to figure this out. I think you need at least a note like:
| Installing Podman | |
| **NOTE:** The documentation talks about Podman 6.0 in several of the following sections of this document. At the time of this writing, Podman 6.0 is expected to be released in the Spring of 2026. Until that time, this functionality is only available from the [`main`](https:/github.com/containers/podman) release branch in Podman's GitHub Repository. | |
| Installing Podman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For clarification: this PR targets Podman main branch, where the v6.0 source code and documentation live. This particular markdown file is built and included in the v6.0.0 installer (that hasn't been released yet but can already be manually built) and presented to the user after installation of v6.0.0 of Podman. If the user installs Podman a previous version, such as current stable v5.7.1, he will see the version inclued in that installer, not this version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the Podman documentation website though, even if a users chose to read v5.7.1 of the doc, they will be redirected to main branch tutorial, which is problematic, but can't be addressed by this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomSweeneyRedHat I haven't added the note as this PR includes two versions of the same tutorial: one version for Podman v5.7 (in a separate commit, ready to be cherry picked) and another version for Podman v6.0. Hence a Podman v5.7 user should see the right version of the documentation. Are you ok with that?
|
Other than the 6.0 references and one tiny nit, LGTM. |
|
I'm fine with tending to those post merge. |
|
LGTM, one nit |
9285aa0 to
0948df1
Compare
Signed-off-by: Mario Loriedo <[email protected]>
0948df1 to
6f2df1e
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
mtrmac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know ~nothing about the subject; noting this has had 2-3 LGTMs already. I plan to merge after updating the Control Panel reference.
Signed-off-by: Mario Loriedo <[email protected]>
6f2df1e to
87df3e4
Compare
Thank you for the review @mtrmac. |

The windows-tutorial is the first documentation article that we show to a user that has installed podman on Windows. It hasn't been updated since a long time.
The PR includes two distinc commit. One that includes the updates up until v5.7.1 of Podman and a second one with the updates between v5.7.1 and v6.0.0.
Previews of the HTML generated from the md file with pandoc are available on :
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?