Quadlet - do not link pod service units to quadlet templates

[ygalblum]

When a template container unit is linked to a pod do not add its service to the pod units dependency

Resolves: #27844

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

• Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
  commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
  the sign-off email address. See CONTRIBUTING.md
  for more information.
• Referenced issues using Fixes: #00000 in commit message (if applicable)
• Tests have been added/updated (or no tests are needed)
• Documentation has been updated (or no documentation changes are needed)
• All commits pass make validatepr (format/lint checks)
• Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

Quadlet - Do not link pod service units to template container service units

[baude]

LGTM

[TomSweeneyRedHat]

LGTM

[TomSweeneyRedHat]

/lgtm

[jankaluza]

LGTM.

I spent time thinking if we should search for @ or @.. The thing is that strictly speaking, template is just [email protected]. If there is a [email protected], it is an instance of that template afaik. The isTemplateUnit currently matches both templates and instances, but I think it is fine in this context.

Just saying that in case someone with more experience with this code would find this an issue.

[ygalblum]

@jankaluza good catch. I've fixed the code. Note that it required reverting part of the change since in the other cases, the check is in fact for "template or an instance of a template".
I've updated the test as well. PTAL

[ygalblum]

BTW is there an issue with the bot? @TomSweeneyRedHat's LGTM did not trigger any labeling (and as a result the PR did not merge already)

[TomSweeneyRedHat]

@ygalblum this is the second time this week the bot has ignored my merge request. @bbaude do you know what's going on?