secrets/create: remove pipe check and allow interactive stdin #27904
+24
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `secret create` required stdin to be a pipe when using `-`, blocking interactive stdin forcing users to use insecure patterns like `echo "secret" | podman secret create <name>`. Remove the pipe check to allow interactive stdin. Closes containers#18591, containers#27879 Signed-off-by: Danish Prakash <[email protected]>
danishprakash
force-pushed
the
secret-pipe-check
branch
from
cb8587c to
86a3b68
Compare
Member
|
Changes LGTM |
jankaluza
approved these changes
Jan 15, 2026
Member
|
The failed tft tests are not related to this change. The issue is in the tft I think. |
Collaborator
|
/packit retest-failed |
|
Account inknos has no write access nor is author of PR! |
Member
|
/packit retest-failed |
|
Account jankaluza has no write access nor is author of PR! |
Member
|
/packit retest-failed |
ashley-cui
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
secret createrequired stdin to be a pipe when using-, blocking interactive stdin forcing users to use insecure patterns likeecho "secret" | podman secret create <name>.Remove the pipe check to allow interactive stdin.
Closes #18591, #27879