watchtower hooks not working

[dev2021-ctrl]

Hi

I am using pre update hooks in watchtower but the below commands does not even trigger the shell script.
Basically i want to skip update based on shell script
Also this env variable set WATCHTOWER_LIFECYCLE_HOOKS to true

docker run  -d --label=com.centurylinklabs.watchtower.lifecycle.pre-check="/dump-data.sh" \
--restart always \
--name watchtower \
-v /var/run/docker.sock:/var/run/docker.sock \
containrrr/watchtower \
--cleanup \
--interval 10 --enable-lifecycle-hooks \
test

Pleae help a bit urgent
I am pretty sure the latest watchtower build here https://github.com/containrrr/watchtower supports this skipping update feature

Logs :

time="2021-06-28T15:21:17Z" level=info msg="Watchtower 1.3.0\nUsing no notifications\nOnly checking containers with name \"validator\"\nScheduling first run: 2021-06-28 15:21:27 +0000 UTC\nNote that the first check will be performed in 9 seconds"

[github-actions]

Hi there! 👋🏼 As you're new to this repo, we'd like to suggest that you read our code of conduct as well as our contribution guidelines. Thanks a bunch for opening your first issue! 🙏

[dev2021-ctrl]

Already read it and posted the bug above
please help

[piksel]

Look at the examples in the docs for examples of how to use the hooks:
https://containrrr.dev/watchtower/lifecycle-hooks/

You are currently telling watchtower to only check the container "test" and run any lifecycle-hooks on it before/after checking/updating it.
But the label with the hook is passed to the watchtower container (which neither contain sh, nor the specified script dump-data.sh).

[piksel]

I am pretty sure the latest watchtower build here https://github.com/containrrr/watchtower supports this skipping update feature

I think you are referring to #793, no? That has been merged, but it's not released yet.
You can use containrrr/watchtower:latest-dev to try it out!

[dev2021-ctrl]

ok thanks I am now creating shell script inside the container and running it now Will update in few mins

…

On Tue, Jun 29, 2021 at 3:11 PM nils måsén ***@***.***> wrote: I am pretty sure the latest watchtower build here https://github.com/containrrr/watchtower supports this skipping update feature I think you are referring to #793 <#793>, no? That has been merged, but it's not released yet. You can use containrrr/watchtower:latest-dev to try it out! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1004 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AT3CT6BDGI55NAQ2SCGGVJTTVGINDANCNFSM47OHL4NA> .

[dev2021-ctrl]

I assume with latest-dev if the label pre update check fails due to exit code other than 0 , the watchtower wont update and will retry after set interval. Correct

…

On Tue, Jun 29, 2021 at 3:11 PM nils måsén ***@***.***> wrote: I am pretty sure the latest watchtower build here https://github.com/containrrr/watchtower supports this skipping update feature I think you are referring to #793 <#793>, no? That has been merged, but it's not released yet. You can use containrrr/watchtower:latest-dev to try it out! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1004 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AT3CT6BDGI55NAQ2SCGGVJTTVGINDANCNFSM47OHL4NA> .

[dev2021-ctrl]

@piksel can you please let me know how to create that pre update scrupt inside container.
I tried
docker run -it "containrrr/watchtower:latest-dev" bash
but not workin

[dev2021-ctrl]

Look at the examples in the docs for examples of how to use the hooks:
https://containrrr.dev/watchtower/lifecycle-hooks/

You are currently telling watchtower to only check the container "test" and run any lifecycle-hooks on it before/after checking/updating it.
But the label with the hook is passed to the watchtower container (which neither contain sh, nor the specified script dump-data.sh).

Can you please share the complete commands.I am confused

[piksel]

I am not sure what you are trying to do, but to run a container that will have it's script executed at the start of every update-session, you can use the following:

docker run -d \
  --label=com.centurylinklabs.watchtower.lifecycle.pre-check="/dump-data.sh" \
  --name validator \
  your-validator/image:latest

where your-validator/image contains the /dump-data.sh script you want to run

Then run watchtower(-dev) with lifecycle hooks enabled:

docker run -d  \
  --name watchtower \
  -v /var/run/docker.sock:/var/run/docker.sock \
  containrrr/watchtower:latest-dev \
  --debug \
  --interval 10 --enable-lifecycle-hooks \
  validator

[dev2021-ctrl]

i wil check thanks

…

On Tue, Jun 29, 2021 at 4:10 PM nils måsén ***@***.***> wrote: I am not sure what you are trying to do, but to run a container that will have it's script executed at the start of every update-session, you can use the following: docker run -d \ --label=com.centurylinklabs.watchtower.lifecycle.pre-check="/dump-data.sh" \ --name validator \ your-validator/image:latest where your-validator/image contains the /dump-data.sh script you want to run Then run watchtower(-dev) with lifecycle hooks enabled: docker run -d \ --name watchtower \ -v /var/run/docker.sock:/var/run/docker.sock \ containrrr/watchtower-dev \ --debug \ --interval 10 --enable-lifecycle-hooks \ validator — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1004 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AT3CT6GEB7U63PLCPKHXO5TTVGPKRANCNFSM47OHL4NA> .

[dev2021-ctrl]

I am not sure what you are trying to do, but to run a container that will have it's script executed at the start of every update-session, you can use the following:

docker run -d \
  --label=com.centurylinklabs.watchtower.lifecycle.pre-check="/dump-data.sh" \
  --name validator \
  your-validator/image:latest

where your-validator/image contains the /dump-data.sh script you want to run

Then run watchtower(-dev) with lifecycle hooks enabled:

docker run -d  \
  --name watchtower \
  -v /var/run/docker.sock:/var/run/docker.sock \
  containrrr/watchtower-dev \
  --debug \
  --interval 10 --enable-lifecycle-hooks \
  validator

Basicay i want to update my validator image based on the below condition
The condition will be:
if (docker exec validator miner info in_consensus) = false
then (watchtower can update)
else (watchtower can NOT update)

I am wondering I can create dump-data.sh script and add to validator container.
If it is false then I can make shell script return non zero code and the update wil be skipped by watchtower.

I assume the above logic will work

[dev2021-ctrl]

I am using above commands but cannot see any labels present when doing inspect
docker image inspect --format='' "quay.io/team-helium/validator:latest-validator-amd64"

This is the docker for validator
docker run -d --label=com.centurylinklabs.watchtower.lifecycle.pre-update="/dump.sh" --init
--restart always
--publish 2154:2154/tcp
--name validator
--mount type=bind,source=$HOME/validator_data,target=/var/data
quay.io/team-helium/validator:latest-validator-amd64

please advise
a bit urgent