Skip to content

Conversation

@ksurl
Copy link
Contributor

@ksurl ksurl commented May 23, 2022

adds pip caching and python versioning for docs publishing workflow

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #1292 (b0fb277) into main (2fa8a2a) will increase coverage by 1.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1292      +/-   ##
==========================================
+ Coverage   61.89%   63.13%   +1.23%     
==========================================
  Files          23       23              
  Lines        1475     1530      +55     
==========================================
+ Hits          913      966      +53     
+ Misses        476      474       -2     
- Partials       86       90       +4     
Impacted Files Coverage Δ
pkg/api/api.go 39.28% <0.00%> (-4.05%) ⬇️
internal/actions/update.go 63.07% <0.00%> (-0.49%) ⬇️
pkg/container/container.go 51.92% <0.00%> (ø)
pkg/notifications/email.go 90.69% <0.00%> (ø)
pkg/notifications/msteams.go 66.66% <0.00%> (ø)
internal/flags/flags.go 89.11% <0.00%> (+0.46%) ⬆️
pkg/notifications/shoutrrr.go 74.69% <0.00%> (+1.62%) ⬆️
pkg/notifications/notifier.go 84.93% <0.00%> (+14.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fa8a2a...b0fb277. Read the comment docs.

Copy link
Member

@piksel piksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, why not?

@piksel piksel changed the title add pip caching for docs workflow ci: add pip caching for docs workflow May 24, 2022
@piksel piksel merged commit 3e4b269 into containrrr:main May 24, 2022
@piksel
Copy link
Member

piksel commented May 24, 2022

@all-contributors please add @ksurl for infra

@piksel
Copy link
Member

piksel commented May 24, 2022

@all-contributors please add @ksurl for infra

@allcontributors
Copy link
Contributor

@piksel

I've put up a pull request to add @ksurl! 🎉

@ksurl ksurl deleted the doc-pip-cache branch May 24, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants