Pass in HostConfig to create operation #15
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiehannaford
changed the title
added 2 commits
March 15, 2016 17:12
jamiehannaford
changed the title
Author
|
@bdehamer Hey, would you mind taking a look at this if you have any free time? Thanks! |
Contributor
|
Resolved by #26. This PR could be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes three problems:
CreateContainerfunction in dockerclient now accepts a third argument for auth config.RemoveImagefunction in dockerclient now accepts a second bool argument.Apart from not being able to build, another bug is that HostConfig information is not adhered to when containers are redeployed (e.g. their port mappings).