Skip to content

Conversation

@piksel
Copy link
Member

@piksel piksel commented Oct 23, 2023

Only perform the container.GetCreateConfig default value override dance for healthcheck when it's actually present in both container and image config.

Fixes #1809

@piksel piksel requested a review from simskij as a code owner October 23, 2023 08:19
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd54055) 70.61% compared to head (dee7d6a) 70.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1810      +/-   ##
==========================================
+ Coverage   70.61%   70.63%   +0.01%     
==========================================
  Files          26       26              
  Lines        2488     2489       +1     
==========================================
+ Hits         1757     1758       +1     
  Misses        631      631              
  Partials      100      100              
Files Coverage Δ
pkg/container/container.go 71.15% <100.00%> (+0.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piksel piksel merged commit c4d4938 into main Oct 23, 2023
@piksel piksel deleted the fix/getconfignil branch October 23, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

:latest-dev fails on image updates and is removing containers

2 participants