Check for host network mode #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Fixes #73. Thank you very much for your contribution. |
|
Has this been released? I've pulled the latest watchtower I am still having this issue. |
Contributor
Author
|
@bjeanes Seeing this has been tagged for 0.1.1 and hub image is still 0.1.0 I don't think so, but I am using my own image build so I might be wrong |
|
@stffabi any ETA for a 0.1.1 release? |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searching for the error message from #73 in docker's API allowed me to backtrack the throwing function in NetworkDisconnect which is used in StartContainer.
After reading a bit around (here, here and the conditions), I believe host network mode can be only exclusive, so I wrapped the offending code in a conditional block and so far it seems to work for me