feat(log): use short image/container IDs in logs #888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #888 +/- ##
=======================================
Coverage ? 43.49%
=======================================
Files ? 25
Lines ? 1391
Branches ? 0
=======================================
Hits ? 605
Misses ? 725
Partials ? 61 Continue to review full report at Codecov.
|
piksel
commented
Apr 8, 2021
Comment on lines
-287
to
+295
| if opts.RegistryAuth != "" { | ||
| log.Debug("Credentials loaded") | ||
| } | ||
| if err != nil { | ||
| log.Debugf("Error loading authentication credentials %s", err) | ||
| return err | ||
| } | ||
| if opts.RegistryAuth != "" { | ||
| log.Debug("Credentials loaded") | ||
| } |
Member
Author
There was a problem hiding this comment.
Not actually part of the intended changes, but got a lint warning about the use of opts before checking if an error was returned. Shouldn't matter, but doing it in this order is at least more correct.
simskij
approved these changes
Apr 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should clean up the logging output and only refer to images and containers using their short hashes.
ref #873