[WIP]Add grouping by week#533
[WIP]Add grouping by week#533cliffparnitzky wants to merge 4 commits intocontao-community-alliance:masterfrom cliffparnitzky-forks:master
Conversation
Implements the backend grouping by week
| if ('' === $value) { | ||
| return '-'; | ||
| } | ||
| $event = new ParseDateEvent($value, 'W. Y'); |
There was a problem hiding this comment.
Adjust the output of the new grouping. The monthly grouping already exists. This output should not differ.
There was a problem hiding this comment.
The W. creates the numer of the number of the week in current year.
There was a problem hiding this comment.
I meant please remove the dot.
There was a problem hiding this comment.
hmm...
with the month, the issue is not the number, but the name... I'm not sure if it's better with or without a dot...
There was a problem hiding this comment.
I think without the dot we need somtehing else (e.g. KW as prefix).
There was a problem hiding this comment.
@cliffparnitzky Sorry, I misread the format of the grouping for the month.
There was a problem hiding this comment.
we should add a default date format and override this with date format from language file
But you should note that the weeks start differently - in DE on Monday, in UK/US on Sunday
see https://de.wikipedia.org/wiki/Woche#Kalenderwoche
When grouped by week, it should therefore be possible to select an additional calculation - currently the "German" according to ISO8601
There was a problem hiding this comment.
I am also all for providing/using language keys for the formats.
|
@baumannsven @zonky2 Additional proposal: I can also add the last missing grouping option, which is ``. But we should decide the format first (have a look at the option here: https://www.php.net/manual/de/function.date.php). What about |
In mumble we decided to create different PRs for each option. |
|
? ? ? |
|
Hmmm, Mist, hab hier irgendwas gemacht, was ich nicht wollte. |
|
Wie mit @zonky2 besprochen mache ich den PR nochmal neu auf den neusten Branch. Grundsätzlich wie bereits implementiert, aber eben mit Language Keys für die Ausgabe.
|
|
Follow up PR is #616 |
Hotfix release 2.3.2 - Fix undefined array key problem - Fix limit of list - Fix request token at change language - Add grouping by week (replaces #533) - Fix code style in templates
5 participants
Implements the backend grouping by week
Checklist
@authorsin touched PHP files